From 8838710cae09a9ed785530abc48e08d9231b1712 Mon Sep 17 00:00:00 2001 From: Emmanuel Okedele Date: Thu, 17 Jul 2025 07:58:54 +0100 Subject: [PATCH 1/2] Switching from list comprehension to np.fromiter converts this to an nd.array and resolves mypy error --- pymc/sampling/mcmc.py | 2 +- scripts/run_mypy.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/pymc/sampling/mcmc.py b/pymc/sampling/mcmc.py index 542797caa..ddb0cdc4f 100644 --- a/pymc/sampling/mcmc.py +++ b/pymc/sampling/mcmc.py @@ -760,7 +760,7 @@ def joined_blas_limiter(): UserWarning, ) rngs = get_random_generator(random_seed).spawn(chains) - random_seed_list = [rng.integers(2**30) for rng in rngs] + random_seed_list = np.fromiter((rng.integers(2**30) for rng in rngs), dtype=np.int64) if not discard_tuned_samples and not return_inferencedata and not isinstance(trace, ZarrTrace): warnings.warn( diff --git a/scripts/run_mypy.py b/scripts/run_mypy.py index 032fbc938..3f104684a 100755 --- a/scripts/run_mypy.py +++ b/scripts/run_mypy.py @@ -44,7 +44,6 @@ pymc/model/transform/conditioning.py pymc/pytensorf.py pymc/sampling/jax.py -pymc/sampling/mcmc.py """ From 7e7db25b7e59a9a957b86b237abaa82c2a71c87d Mon Sep 17 00:00:00 2001 From: Emmanuel Okedele Date: Fri, 18 Jul 2025 09:29:23 +0100 Subject: [PATCH 2/2] temporarily added as failing until numpy is upgraded to > 2.3 --- scripts/run_mypy.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/run_mypy.py b/scripts/run_mypy.py index 3f104684a..032fbc938 100755 --- a/scripts/run_mypy.py +++ b/scripts/run_mypy.py @@ -44,6 +44,7 @@ pymc/model/transform/conditioning.py pymc/pytensorf.py pymc/sampling/jax.py +pymc/sampling/mcmc.py """