From 1bc7885fda3fa33d8d59480ad6c4c82230475dc4 Mon Sep 17 00:00:00 2001 From: jan iversen Date: Thu, 2 Oct 2025 10:55:43 +0000 Subject: [PATCH 1/5] Remove test pymodbus.log file. --- .gitignore | 1 - test/global/test_logging.py | 5 ++++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 9a51b9e6e..4a00e8802 100644 --- a/.gitignore +++ b/.gitignore @@ -19,5 +19,4 @@ build/html /pymodbus.egg-info/ venv downloaded_files/ -pymodbus.log *.lock diff --git a/test/global/test_logging.py b/test/global/test_logging.py index f04149ffc..b7986b14f 100644 --- a/test/global/test_logging.py +++ b/test/global/test_logging.py @@ -1,6 +1,7 @@ """Test datastore.""" import logging from unittest import mock +from os import remove import pytest @@ -47,7 +48,8 @@ def test_log_parms(self, txt, result, params): def test_apply_logging(self): """Test pymodbus_apply_logging_config.""" - pymodbus_apply_logging_config("debug", "pymodbus.log") + LOG_FILE = "pymodbus.log" + pymodbus_apply_logging_config("debug", LOG_FILE) pymodbus_apply_logging_config("info") pymodbus_apply_logging_config(logging.NOTSET) Log.debug("test 1no") @@ -83,6 +85,7 @@ def test_apply_logging(self): Log.info("test 5") Log.info("test 5") Log.info("test 5") + remove(LOG_FILE) def test_apply_build_no(self): """Test pymodbus_apply_logging_config.""" From 992ba7a9c32ea50b589f2b3f30c3aadb8cf2d60c Mon Sep 17 00:00:00 2001 From: jan iversen Date: Thu, 2 Oct 2025 10:59:12 +0000 Subject: [PATCH 2/5] ruff. --- test/global/test_logging.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/global/test_logging.py b/test/global/test_logging.py index b7986b14f..77c8a4d4e 100644 --- a/test/global/test_logging.py +++ b/test/global/test_logging.py @@ -1,7 +1,7 @@ """Test datastore.""" import logging -from unittest import mock from os import remove +from unittest import mock import pytest From bf6c77aa51011a2d46cb5ebeea8407140cdd6085 Mon Sep 17 00:00:00 2001 From: jan iversen Date: Thu, 2 Oct 2025 11:10:26 +0000 Subject: [PATCH 3/5] Change test log file. --- test/global/test_logging.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/global/test_logging.py b/test/global/test_logging.py index 77c8a4d4e..b0975ed03 100644 --- a/test/global/test_logging.py +++ b/test/global/test_logging.py @@ -48,7 +48,7 @@ def test_log_parms(self, txt, result, params): def test_apply_logging(self): """Test pymodbus_apply_logging_config.""" - LOG_FILE = "pymodbus.log" + LOG_FILE = "pymodbus_apply.log" pymodbus_apply_logging_config("debug", LOG_FILE) pymodbus_apply_logging_config("info") pymodbus_apply_logging_config(logging.NOTSET) From 215f6681d3593bdfdcedc001e4b2ae1766845f42 Mon Sep 17 00:00:00 2001 From: jan iversen Date: Thu, 2 Oct 2025 11:24:07 +0000 Subject: [PATCH 4/5] Shutdown logging. --- test/global/test_logging.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/global/test_logging.py b/test/global/test_logging.py index b0975ed03..d499f3441 100644 --- a/test/global/test_logging.py +++ b/test/global/test_logging.py @@ -48,7 +48,7 @@ def test_log_parms(self, txt, result, params): def test_apply_logging(self): """Test pymodbus_apply_logging_config.""" - LOG_FILE = "pymodbus_apply.log" + LOG_FILE = "pymodbus.log" pymodbus_apply_logging_config("debug", LOG_FILE) pymodbus_apply_logging_config("info") pymodbus_apply_logging_config(logging.NOTSET) @@ -85,7 +85,7 @@ def test_apply_logging(self): Log.info("test 5") Log.info("test 5") Log.info("test 5") - remove(LOG_FILE) + logging.shutdown() def test_apply_build_no(self): """Test pymodbus_apply_logging_config.""" From b25e24191ac28ac708247bfa0d469807ace2ba3e Mon Sep 17 00:00:00 2001 From: jan iversen Date: Thu, 2 Oct 2025 11:25:14 +0000 Subject: [PATCH 5/5] Ruff. --- test/global/test_logging.py | 1 - 1 file changed, 1 deletion(-) diff --git a/test/global/test_logging.py b/test/global/test_logging.py index d499f3441..c24bc989b 100644 --- a/test/global/test_logging.py +++ b/test/global/test_logging.py @@ -1,6 +1,5 @@ """Test datastore.""" import logging -from os import remove from unittest import mock import pytest