From 658dd7e87456fba38860402422641293a2597272 Mon Sep 17 00:00:00 2001 From: Mike Brennan Date: Mon, 1 May 2023 13:29:32 -0400 Subject: [PATCH 1/5] add priorityClassName to DaemonSet --- chart/pyroscope-ebpf/Chart.yaml | 2 +- chart/pyroscope-ebpf/README.md | 3 ++- chart/pyroscope-ebpf/templates/daemonset.yaml | 3 +++ chart/pyroscope-ebpf/values.yaml | 4 ++++ 4 files changed, 10 insertions(+), 2 deletions(-) diff --git a/chart/pyroscope-ebpf/Chart.yaml b/chart/pyroscope-ebpf/Chart.yaml index e26a2c9..0ce31b8 100644 --- a/chart/pyroscope-ebpf/Chart.yaml +++ b/chart/pyroscope-ebpf/Chart.yaml @@ -2,5 +2,5 @@ apiVersion: v2 name: pyroscope-ebpf description: A Helm chart for Pyroscope eBPF type: application -version: 0.1.31 +version: 0.1.32 appVersion: "0.37.2" diff --git a/chart/pyroscope-ebpf/README.md b/chart/pyroscope-ebpf/README.md index c285cff..47e1cdb 100644 --- a/chart/pyroscope-ebpf/README.md +++ b/chart/pyroscope-ebpf/README.md @@ -1,6 +1,6 @@ # pyroscope-ebpf -![Version: 0.1.31](https://img.shields.io/badge/Version-0.1.31-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.37.2](https://img.shields.io/badge/AppVersion-0.37.2-informational?style=flat-square) +![Version: 0.1.32](https://img.shields.io/badge/Version-0.1.32-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.37.2](https://img.shields.io/badge/AppVersion-0.37.2-informational?style=flat-square) A Helm chart for Pyroscope eBPF @@ -42,6 +42,7 @@ helm delete my-release | image.pullPolicy | string | `"IfNotPresent"` | Image pull policy | | image.repository | string | `"pyroscope/pyroscope"` | image to use for deploying | | image.tag | string | `"0.37.2"` | Tag for pyroscope image to use | +| priorityClassName | string | `""` | Set priorityClassName for pyroscope-ebpf on DaemonSet to have a higher priority over other pods | | serviceAccount.annotations | object | `{}` | ServiceAccount annotations | | serviceAccount.create | bool | `true` | Create service account | | serviceAccount.name | string | `""` | Service account name to use, when empty will be set to created account if serviceAccount.create is set else to default | diff --git a/chart/pyroscope-ebpf/templates/daemonset.yaml b/chart/pyroscope-ebpf/templates/daemonset.yaml index 1be092c..129b6b7 100644 --- a/chart/pyroscope-ebpf/templates/daemonset.yaml +++ b/chart/pyroscope-ebpf/templates/daemonset.yaml @@ -19,6 +19,9 @@ spec: tolerations: {{- toYaml . | nindent 8 }} {{- end }} + {{- if .Values.priorityClassName }} + priorityClassName: {{ .Values.priorityClassName }} + {{- end }} {{- with .Values.nodeSelector }} nodeSelector: {{- toYaml . | nindent 8 }} diff --git a/chart/pyroscope-ebpf/values.yaml b/chart/pyroscope-ebpf/values.yaml index bb8da53..9994529 100644 --- a/chart/pyroscope-ebpf/values.yaml +++ b/chart/pyroscope-ebpf/values.yaml @@ -22,6 +22,10 @@ serviceAccount: # -- ServiceAccount annotations annotations: {} +# -- PriorityClassName to schedule pod with higher priority +# priorityClassName: "system-node-critical" +# -- PriorityClassName to schedule pod with higher priority +priorityClassName: "system-node-critical" # -- Arguments to be passed to the pyroscope binary args: From 2c65cf867fc6bc5602160aa7dc674f788fe2a2a2 Mon Sep 17 00:00:00 2001 From: Mike Brennan Date: Mon, 1 May 2023 13:30:39 -0400 Subject: [PATCH 2/5] add priorityClassName to DaemonSet --- chart/pyroscope-ebpf/values.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/chart/pyroscope-ebpf/values.yaml b/chart/pyroscope-ebpf/values.yaml index 9994529..7f607cb 100644 --- a/chart/pyroscope-ebpf/values.yaml +++ b/chart/pyroscope-ebpf/values.yaml @@ -24,8 +24,6 @@ serviceAccount: # -- PriorityClassName to schedule pod with higher priority # priorityClassName: "system-node-critical" -# -- PriorityClassName to schedule pod with higher priority -priorityClassName: "system-node-critical" # -- Arguments to be passed to the pyroscope binary args: From 40440a06dc853ec8408ccef921e30eed0a89455c Mon Sep 17 00:00:00 2001 From: Mike Brennan Date: Mon, 1 May 2023 14:35:23 -0400 Subject: [PATCH 3/5] add priorityClassName to helm chart --- chart/pyroscope-ebpf/Chart.yaml | 2 +- chart/pyroscope-ebpf/README.md | 3 ++- chart/pyroscope-ebpf/templates/daemonset.yaml | 3 +++ chart/pyroscope-ebpf/values.yaml | 2 ++ 4 files changed, 8 insertions(+), 2 deletions(-) diff --git a/chart/pyroscope-ebpf/Chart.yaml b/chart/pyroscope-ebpf/Chart.yaml index e26a2c9..0ce31b8 100644 --- a/chart/pyroscope-ebpf/Chart.yaml +++ b/chart/pyroscope-ebpf/Chart.yaml @@ -2,5 +2,5 @@ apiVersion: v2 name: pyroscope-ebpf description: A Helm chart for Pyroscope eBPF type: application -version: 0.1.31 +version: 0.1.32 appVersion: "0.37.2" diff --git a/chart/pyroscope-ebpf/README.md b/chart/pyroscope-ebpf/README.md index c285cff..47e1cdb 100644 --- a/chart/pyroscope-ebpf/README.md +++ b/chart/pyroscope-ebpf/README.md @@ -1,6 +1,6 @@ # pyroscope-ebpf -![Version: 0.1.31](https://img.shields.io/badge/Version-0.1.31-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.37.2](https://img.shields.io/badge/AppVersion-0.37.2-informational?style=flat-square) +![Version: 0.1.32](https://img.shields.io/badge/Version-0.1.32-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.37.2](https://img.shields.io/badge/AppVersion-0.37.2-informational?style=flat-square) A Helm chart for Pyroscope eBPF @@ -42,6 +42,7 @@ helm delete my-release | image.pullPolicy | string | `"IfNotPresent"` | Image pull policy | | image.repository | string | `"pyroscope/pyroscope"` | image to use for deploying | | image.tag | string | `"0.37.2"` | Tag for pyroscope image to use | +| priorityClassName | string | `""` | Set priorityClassName for pyroscope-ebpf on DaemonSet to have a higher priority over other pods | | serviceAccount.annotations | object | `{}` | ServiceAccount annotations | | serviceAccount.create | bool | `true` | Create service account | | serviceAccount.name | string | `""` | Service account name to use, when empty will be set to created account if serviceAccount.create is set else to default | diff --git a/chart/pyroscope-ebpf/templates/daemonset.yaml b/chart/pyroscope-ebpf/templates/daemonset.yaml index 1be092c..129b6b7 100644 --- a/chart/pyroscope-ebpf/templates/daemonset.yaml +++ b/chart/pyroscope-ebpf/templates/daemonset.yaml @@ -19,6 +19,9 @@ spec: tolerations: {{- toYaml . | nindent 8 }} {{- end }} + {{- if .Values.priorityClassName }} + priorityClassName: {{ .Values.priorityClassName }} + {{- end }} {{- with .Values.nodeSelector }} nodeSelector: {{- toYaml . | nindent 8 }} diff --git a/chart/pyroscope-ebpf/values.yaml b/chart/pyroscope-ebpf/values.yaml index bb8da53..7f607cb 100644 --- a/chart/pyroscope-ebpf/values.yaml +++ b/chart/pyroscope-ebpf/values.yaml @@ -22,6 +22,8 @@ serviceAccount: # -- ServiceAccount annotations annotations: {} +# -- PriorityClassName to schedule pod with higher priority +# priorityClassName: "system-node-critical" # -- Arguments to be passed to the pyroscope binary args: From bff4d41e6cd696709441fe7be4f048f47a419b89 Mon Sep 17 00:00:00 2001 From: bmike78 Date: Tue, 30 May 2023 12:05:43 -0400 Subject: [PATCH 4/5] run helm-docs --- chart/pyroscope-ebpf/README.md | 2 +- chart/pyroscope-ebpf/values.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/chart/pyroscope-ebpf/README.md b/chart/pyroscope-ebpf/README.md index 47e1cdb..4ea13f7 100644 --- a/chart/pyroscope-ebpf/README.md +++ b/chart/pyroscope-ebpf/README.md @@ -42,7 +42,7 @@ helm delete my-release | image.pullPolicy | string | `"IfNotPresent"` | Image pull policy | | image.repository | string | `"pyroscope/pyroscope"` | image to use for deploying | | image.tag | string | `"0.37.2"` | Tag for pyroscope image to use | -| priorityClassName | string | `""` | Set priorityClassName for pyroscope-ebpf on DaemonSet to have a higher priority over other pods | +| priorityClassName | string | `""` | PriorityClassName to schedule pod with higher priority | | serviceAccount.annotations | object | `{}` | ServiceAccount annotations | | serviceAccount.create | bool | `true` | Create service account | | serviceAccount.name | string | `""` | Service account name to use, when empty will be set to created account if serviceAccount.create is set else to default | diff --git a/chart/pyroscope-ebpf/values.yaml b/chart/pyroscope-ebpf/values.yaml index 7f607cb..1479e0a 100644 --- a/chart/pyroscope-ebpf/values.yaml +++ b/chart/pyroscope-ebpf/values.yaml @@ -23,7 +23,7 @@ serviceAccount: annotations: {} # -- PriorityClassName to schedule pod with higher priority -# priorityClassName: "system-node-critical" +priorityClassName: "" # -- Arguments to be passed to the pyroscope binary args: From c0a5aa73c19285ec2620ec1d1c3a2f5b5243b02a Mon Sep 17 00:00:00 2001 From: bmike78 Date: Thu, 10 Aug 2023 13:13:12 -0400 Subject: [PATCH 5/5] ran helm-docs --- chart/pyroscope-ebpf/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chart/pyroscope-ebpf/README.md b/chart/pyroscope-ebpf/README.md index 4ea13f7..be70a31 100644 --- a/chart/pyroscope-ebpf/README.md +++ b/chart/pyroscope-ebpf/README.md @@ -42,7 +42,7 @@ helm delete my-release | image.pullPolicy | string | `"IfNotPresent"` | Image pull policy | | image.repository | string | `"pyroscope/pyroscope"` | image to use for deploying | | image.tag | string | `"0.37.2"` | Tag for pyroscope image to use | -| priorityClassName | string | `""` | PriorityClassName to schedule pod with higher priority | +| priorityClassName | string | `"system-node-critical"` | PriorityClassName to schedule pod with higher priority | | serviceAccount.annotations | object | `{}` | ServiceAccount annotations | | serviceAccount.create | bool | `true` | Create service account | | serviceAccount.name | string | `""` | Service account name to use, when empty will be set to created account if serviceAccount.create is set else to default |