refactor: address most review comments (thanks @wookie184)

Author: Strengthless

bot/exts/fun/adventure.py

@@ -3,28 +3,18 @@
 import json
 from contextlib import suppress
 from pathlib import Path
-from typing import Literal, NamedTuple, NotRequired, TypedDict
+from typing import Literal, NotRequired, TypedDict
 
 from discord import Embed, HTTPException, Message, Reaction, User
 from discord.ext import commands
-from discord.ext.commands import Cog as DiscordCog, Command, Context
+from discord.ext.commands import Cog as DiscordCog, Context
 from pydis_core.utils.logging import get_logger
 
 from bot import constants
 from bot.bot import Bot
 
-
-class Cog(NamedTuple):
-    """Show information about a Cog's name, description and commands."""
-
-    name: str
-    description: str
-    commands: list[Command]
-
-
 log = get_logger(__name__)
 
-
 class GameInfo(TypedDict):
     """A dictionary containing the game information. Used in `available_games.json`."""
 
@@ -116,8 +106,8 @@ def __init__(
         self.game_info = None
         if game_code_or_index:
             self.game_code = self._parse_game_code(game_code_or_index)
-            self.game_data = self._get_game_data()
             self.game_info = self._get_game_info()
+            self.game_data = self._get_game_data()
 
         # store relevant discord info
         self.author = ctx.author
@@ -142,10 +132,13 @@ def _parse_game_code(self, game_code_or_index: str) -> str:
         # sanitize the game code to prevent directory traversal attacks.
         game_code = Path(game_code_or_index).name
 
-        # convert index to game code if it's a number
+        # convert index to game code if it's a valid number that is in range.
+        # otherwise, return the game code as is, assuming it's a valid game code.
+        # if game code is not valid, errors will be raised later when trying to load the game info.
         try:
             index = int(game_code_or_index)
-            game_code = AVAILABLE_GAMES[index - 1]["id"]
+            if 1 <= index <= len(AVAILABLE_GAMES):
+                game_code = AVAILABLE_GAMES[index - 1]["id"]
         except (ValueError, IndexError):
             pass
 
@@ -162,7 +155,11 @@ def _get_game_data(self) -> GameData | None:
             )
             return game_data
         except FileNotFoundError:
-            raise GameCodeNotFoundError(f'Game code "{game_code}" not found.')
+            log.error(
+                "Game located in `available_games.json`, but game data not found. Game code: %s",
+                game_code
+            )
+            raise GameCodeNotFoundError(f"Game code `{game_code}` not found.")
 
     def _get_game_info(self) -> GameInfo:
         """Returns the game info for the given game code."""
@@ -171,10 +168,7 @@ def _get_game_info(self) -> GameInfo:
         try:
             return AVAILABLE_GAMES_DICT[game_code]
         except KeyError:
-            log.error(
-                "Game data retrieved, but game info not found. Did you forget to add it to `available_games.json`?"
-            )
-            raise GameCodeNotFoundError(f'Game code "{game_code}" not found.')
+            raise GameCodeNotFoundError(f"Game code `{game_code}` not found.")
 
     async def notify_timeout(self) -> None:
         """Notifies the user that the session has timed out."""
@@ -260,15 +254,15 @@ async def prepare(self) -> None:
             await self.send_available_game_codes()
 
 
-    def add_reactions(self) -> None:
+    async def add_reactions(self) -> None:
         """Adds the relevant reactions to the message based on if options are available in the current room."""
         if self.is_in_ending_room:
             return
 
         pickable_emojis = [option["emoji"] for option in self.available_options]
 
         for reaction in pickable_emojis:
-            self._bot.loop.create_task(self.message.add_reaction(reaction))
+            await self.message.add_reaction(reaction)
 
     def _format_room_data(self, room_data: RoomData) -> str:
         """Formats the room data into a string for the embed description."""
@@ -315,7 +309,7 @@ async def update_message(self, room_id: str) -> None:
         if self.is_in_ending_room:
             await self.stop()
         else:
-            self.add_reactions()
+            await self.add_reactions()
 
     @classmethod
     async def start(cls, ctx: Context, game_code_or_index: str | None = None) -> "GameSession":