Increase logging for external commands

The `external_commands.run()` function now logs all environment
variables. Before it only logged extra environment variables defined in
a plugin. The logs were missing information about global environment
variables, e.g. env vars defined in a build container. These additional
env vars influence a build, too.

The run log file now contains the command, env vars, and current
working directory, too.

Signed-off-by: Christian Heimes <cheimes@redhat.com>

Author: tiran

src/fromager/external_commands.py

@@ -70,14 +70,16 @@ def run(
             *cmd,
         ]
 
-    logger.debug(
-        "running: %s %s in %s",
-        " ".join(f"{k}={shlex.quote(v)}" for k, v in extra_environ.items()),
-        " ".join(shlex.quote(str(s)) for s in cmd),
-        cwd or ".",
-    )
+    cmd_str = " ".join(shlex.quote(str(s)) for s in cmd)
+    env_str = " ".join(f"{k}={shlex.quote(v)}" for k, v in sorted(env.items()))
+    cwd_str = cwd or os.path.abspath(os.getcwd())
+
+    logger.debug("running: %s %s in %s", cmd_str, env_str, cwd_str)
     if log_filename:
         with open(log_filename, "w") as log_file:
+            print(f"cmd: {cmd_str}", file=log_file)
+            print(f"env: {env_str}", file=log_file)
+            print(f"cwd: {cwd_str}", file=log_file)
             completed = subprocess.run(
                 cmd,
                 cwd=cwd,