Lbarto/lets try again (DO NOT MERGE) #832
Draft
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lance barto <lance.barto@ibm.com>
Signed-off-by: Lance barto <lance.barto@ibm.com>
Signed-off-by: Lance barto <lance.barto@ibm.com>
Signed-off-by: Lance barto <lance.barto@ibm.com>
Randori-Lance
changed the title
dhellmann
reviewed
Oct 31, 2025
|
|
||
| # Same package with different markers should NOT raise error | ||
| c.add_constraint("baz==1.0; platform_machine != 'ppc64le'") | ||
| c.add_constraint("baz==1.1; platform_machine == 'ppc64le'") |
There was a problem hiding this comment.
It would be good to check here which constraint comes back out. The result should be stable since we don't have a ppc64le test job.
There was a problem hiding this comment.
I thought what I saw running in CI was it running on both x86 and arm64?
There was a problem hiding this comment.
should be able to finagle some "if" statements to do that sort of assertion
There was a problem hiding this comment.
oh, I get it... both would have the same result
There was a problem hiding this comment.
Right, I couldn't remember if we had both CPU types, but I knew for sure we didn't have ppc64le. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.