Skip to content

gh-140748: socket_helper.transient_internet: Unwrap UrlError.__cause__ #140749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2025
Merged

gh-140748: socket_helper.transient_internet: Unwrap UrlError.__cause__ #140749

merged 2 commits into from
Oct 30, 2025

Conversation

@encukou
Copy link
Member

@encukou encukou commented Oct 29, 2025 •
edited by bedevere-app bot
Loading

This might help #140748, and keeps the spirit of the transient_internet decorator.

(See around 8bc0903 and #52820 for some history here.)

@bedevere-app bedevere-app bot mentioned this pull request Oct 29, 2025
Open
@encukou encukou added tests Tests in the Lib/test dir skip news labels Oct 29, 2025
@encukou
Copy link
Member Author

encukou commented Oct 29, 2025

!buildbot Arch

@bedevere-bot
Copy link

bedevere-bot commented Oct 29, 2025

🤖 New build scheduled with the buildbot fleet by @encukou for commit 5f7772c 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140749%2Fmerge

The command will test the builders whose names match following regular expression: Arch

The builders matched are:

  • AMD64 Arch Linux VintageParser PR
  • aarch64 Fedora Rawhide Clang Installed PR
  • AMD64 Arch Linux TraceRefs PR
  • aarch64 Ubuntu 24.04 BigMem PR
  • AMD64 Arch Linux Usan Function PR
  • aarch64 Fedora Stable LTO PR
  • aarch64 CentOS9 LTO PR
  • aarch64 Fedora Rawhide Refleaks PR
  • aarch64 Fedora Stable PR
  • aarch64 Fedora Stable Refleaks PR
  • aarch64 Fedora Rawhide LTO PR
  • AMD64 Arch Linux Perf PR
  • AMD64 Arch Linux Valgrind PR
  • aarch64 RHEL8 PR
  • aarch64 Fedora Stable LTO + PGO PR
  • AMD64 Arch Linux Usan PR
  • AMD64 Arch Linux Asan Debug PR
  • aarch64 Fedora Rawhide Clang PR
  • aarch64 CentOS9 LTO + PGO PR
  • AMD64 Arch Linux Asan PR
  • aarch64 Fedora Rawhide LTO + PGO PR
  • aarch64 Fedora Stable Clang PR
  • aarch64 Fedora Rawhide NoGIL PR
  • aarch64 RHEL8 LTO PR
  • aarch64 CentOS9 Refleaks PR
  • aarch64 RHEL8 LTO + PGO PR
  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • aarch64 Fedora Stable Clang Installed PR
  • aarch64 Fedora Rawhide PR
  • aarch64 RHEL8 Refleaks PR
  • aarch64 Android PR

@encukou
Copy link
Member Author

encukou commented Oct 29, 2025

!buildbot Arch.Linux

@bedevere-bot
Copy link

bedevere-bot commented Oct 29, 2025

🤖 New build scheduled with the buildbot fleet by @encukou for commit 920dd4b 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140749%2Fmerge

The command will test the builders whose names match following regular expression: Arch.Linux

The builders matched are:

  • AMD64 Arch Linux VintageParser PR
  • AMD64 Arch Linux Usan PR
  • AMD64 Arch Linux Asan Debug PR
  • AMD64 Arch Linux TraceRefs PR
  • AMD64 Arch Linux Usan Function PR
  • AMD64 Arch Linux Asan PR
  • AMD64 Arch Linux Perf PR
  • AMD64 Arch Linux Valgrind PR

@encukou encukou marked this pull request as ready for review October 30, 2025 08:58
@encukou
Copy link
Member Author

encukou commented Oct 30, 2025

On the still-failing buildbots, this exposes the #140691 leak.

@encukou encukou merged commit 75a1cbd into python:main Oct 30, 2025
46 of 54 checks passed
@encukou encukou deleted the transient_internet branch October 30, 2025 11:14
@encukou encukou added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 13, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Nov 13, 2025

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

miss-islington-app bot commented Nov 13, 2025

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2025
@encukou @miss-islington
pythongh-140748: socket_helper.transient_internet: Unwrap UrlError.__…
13ca4f7 
…cause__ (pythonGH-140749)

(cherry picked from commit 75a1cbd)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 13, 2025

GH-141505 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 13, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2025
@encukou @miss-islington
pythongh-140748: socket_helper.transient_internet: Unwrap UrlError.__…
1701e3d 
…cause__ (pythonGH-140749)

(cherry picked from commit 75a1cbd)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 13, 2025

GH-141506 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 13, 2025
encukou added a commit that referenced this pull request Nov 13, 2025
@miss-islington @encukou
[3.14] gh-140748: socket_helper.transient_internet: Unwrap UrlError._…
55cf97d 
…_cause__ (GH-140749) (GH-141505)

(cherry picked from commit 75a1cbd)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou added a commit that referenced this pull request Nov 13, 2025
@miss-islington @encukou
[3.13] gh-140748: socket_helper.transient_internet: Unwrap UrlError._…
f50989f 
…_cause__ (GH-140749) (GH-141506)

(cherry picked from commit 75a1cbd)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@encukou @bedevere-bot