From d9d85cd1816353e115d96cd1baf6e29ccbd5e7ba Mon Sep 17 00:00:00 2001 From: Stan Ulbrych Date: Thu, 8 Jan 2026 20:47:34 +0000 Subject: [PATCH 1/4] Stop changes to Tools/check-c-api-docs/ignored_c_api.txt triggering run-tests --- Tools/build/compute-changes.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Tools/build/compute-changes.py b/Tools/build/compute-changes.py index 524d3066fbffa7..cde6a7cfc7d11f 100644 --- a/Tools/build/compute-changes.py +++ b/Tools/build/compute-changes.py @@ -22,6 +22,10 @@ GITHUB_CODEOWNERS_PATH = Path(".github/CODEOWNERS") GITHUB_WORKFLOWS_PATH = Path(".github/workflows") +RUN_TESTS_IGNORE = frozenset({ + Path("Tools/check-c-api-docs/ignored_c_api.txt"), +}) + CONFIGURATION_FILE_NAMES = frozenset({ ".pre-commit-config.yaml", ".ruff.toml", @@ -176,6 +180,7 @@ def process_changed_files(changed_files: Set[Path]) -> Outputs: doc_file or file == GITHUB_CODEOWNERS_PATH or file.name in CONFIGURATION_FILE_NAMES + or file in RUN_TESTS_IGNORE ): run_tests = True From ba9156f350a9d188257b9d7e758efcb9964e1ab4 Mon Sep 17 00:00:00 2001 From: Stan Ulbrych Date: Fri, 9 Jan 2026 16:11:32 +0000 Subject: [PATCH 2/4] Merge sets as req by Peter --- Tools/build/compute-changes.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/Tools/build/compute-changes.py b/Tools/build/compute-changes.py index cde6a7cfc7d11f..7b1dfeb9de8b3c 100644 --- a/Tools/build/compute-changes.py +++ b/Tools/build/compute-changes.py @@ -19,18 +19,16 @@ from collections.abc import Set GITHUB_DEFAULT_BRANCH = os.environ["GITHUB_DEFAULT_BRANCH"] -GITHUB_CODEOWNERS_PATH = Path(".github/CODEOWNERS") GITHUB_WORKFLOWS_PATH = Path(".github/workflows") RUN_TESTS_IGNORE = frozenset({ Path("Tools/check-c-api-docs/ignored_c_api.txt"), + Path(".github/CODEOWNERS"), + Path(".pre-commit-config.yaml"), + Path(".ruff.toml"), + Path("mypy.ini"), }) -CONFIGURATION_FILE_NAMES = frozenset({ - ".pre-commit-config.yaml", - ".ruff.toml", - "mypy.ini", -}) UNIX_BUILD_SYSTEM_FILE_NAMES = frozenset({ Path("aclocal.m4"), Path("config.guess"), @@ -178,8 +176,6 @@ def process_changed_files(changed_files: Set[Path]) -> Outputs: if not ( doc_file - or file == GITHUB_CODEOWNERS_PATH - or file.name in CONFIGURATION_FILE_NAMES or file in RUN_TESTS_IGNORE ): run_tests = True From 8f886b55775d608e2b27974e854413cbb59ac179 Mon Sep 17 00:00:00 2001 From: Stan Ulbrych Date: Fri, 9 Jan 2026 19:16:01 +0000 Subject: [PATCH 3/4] Oneline --- Tools/build/compute-changes.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Tools/build/compute-changes.py b/Tools/build/compute-changes.py index 7b1dfeb9de8b3c..909b63157ceda3 100644 --- a/Tools/build/compute-changes.py +++ b/Tools/build/compute-changes.py @@ -174,10 +174,7 @@ def process_changed_files(changed_files: Set[Path]) -> Outputs: if file.name == "reusable-wasi.yml": platforms_changed.add("wasi") - if not ( - doc_file - or file in RUN_TESTS_IGNORE - ): + if not (doc_file or file in RUN_TESTS_IGNORE): run_tests = True platform = get_file_platform(file) From a8ae13a7dfbb54292e061775d680c2a41531f97d Mon Sep 17 00:00:00 2001 From: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Date: Sat, 10 Jan 2026 12:14:35 +0000 Subject: [PATCH 4/4] Improve condition --- Tools/build/compute-changes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Tools/build/compute-changes.py b/Tools/build/compute-changes.py index 909b63157ceda3..c491f06e9968fe 100644 --- a/Tools/build/compute-changes.py +++ b/Tools/build/compute-changes.py @@ -174,7 +174,7 @@ def process_changed_files(changed_files: Set[Path]) -> Outputs: if file.name == "reusable-wasi.yml": platforms_changed.add("wasi") - if not (doc_file or file in RUN_TESTS_IGNORE): + if not doc_file and file not in RUN_TESTS_IGNORE: run_tests = True platform = get_file_platform(file)