Skip to content

Commit 0376b9e

Browse files
q10facebook-github-bot
authored andcommitted
Remove support for older architectures for PyPI releases (#5181)
Summary: X-link: facebookresearch/FBGEMM#2181 PyPI has a file upload limitation of 600MB for the fbgemm project, and the admins are unwilling to increase the limit. As such, we remove sm 12.0a support from the build, to put the file size back to under 600MB. This onnly affects PyPI packages, as Nova packages will continue to be published with support for SM 8.0, 9.0a, 10.0a, 12.0a Differential Revision: D88325954 Pulled By: q10
1 parent 8b2c265 commit 0376b9e

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

.github/scripts/fbgemm_gpu_build.bash

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,15 @@ __configure_fbgemm_gpu_build_cuda () {
312312
elif [[ $cuda_version_nvcc == *"V13.0"* ]] ||
313313
[[ $cuda_version_nvcc == *"V12.9"* ]] ||
314314
[[ $cuda_version_nvcc == *"V12.8"* ]]; then
315-
local arch_list="8.0;9.0a;10.0a;12.0a"
315+
# NOTE: If we reach this point, then we are building the package for
316+
# publishing to PyPI
317+
if [ "${PYPI_PUBLISH_CHANNEL:-}" = "release" ]; then
318+
# FBGEMM non-nightly releases can be built with a different version of
319+
# CUDA, which migh result in a larger binary size than what PyPI allows.
320+
local arch_list="8.0;9.0a;10.0a"
321+
else
322+
local arch_list="8.0;9.0a;10.0a;12.0a"
323+
fi
316324

317325
elif [[ $cuda_version_nvcc == *"V12.6"* ]] ||
318326
[[ $cuda_version_nvcc == *"V12.4"* ]] ||

.github/workflows/fbgemm_gpu_release_cuda.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,10 @@ jobs:
6565
matrix: ${{ needs.generate-build-matrix.outputs.matrix }}
6666
repo-ref: ${{ github.ref }}
6767
pytorch-channel-version: ${{ (github.event_name == 'workflow_dispatch' && github.event.inputs.pytorch-channel-version) || 'release' }}
68+
extra-env: >-
69+
{
70+
"PYPI_PUBLISH_CHANNEL": "release"
71+
}
6872
6973
generate-test-matrix:
7074
needs: build

0 commit comments

Comments
 (0)