Merge pull request #19 from queueit/bug/php8-internal-funcs-nullable-deprecation

Null check before calling setcookie

Author: Hesi01

KnownUser.php

@@ -423,9 +423,16 @@ public function getCookie($cookieName)
 
     public function setCookie($name, $value, $expire, $domain, $isHttpOnly, $isSecure)
     {
-        if ($domain == null) {
-            $domain = "";
-        }
+        if(is_null($value)){ $value = ""; }
+        
+        if(is_null($expire)){ $expire = 0; }
+        
+        if(is_null($domain)){ $domain = ""; }
+
+        if(is_null($isHttpOnly)){ $isHttpOnly = false; }
+    
+        if(is_null($isSecure)){ $isSecure = false; }
+
         setcookie($name, $value, $expire, "/", $domain, $isSecure, $isHttpOnly);
     }
 

Tests/IntegrationConfigHelpersTest.php

@@ -724,8 +724,8 @@ public function getCookie($cookieName) {
     }
 
     public function setCookie($name, $value, $expire, $domain, $isCookieHttpOnly, $isCookieSecure) {
-        if ($domain == NULL) {
-            $domain = "";
+        if(is_null($value)){
+            $value = "";
         }
         $this->debugInfoCookie = $value;
     }

Tests/KnownUserTest.php

@@ -21,8 +21,8 @@ public function getCookie($cookieName)
 
     public function setCookie($name, $value, $expire, $domain, $isCookieHttpOnly, $isCookieSecure)
     {
-        if ($domain == NULL) {
-            $domain = "";
+        if(is_null($value)){ 
+            $value = ""; 
         }
         $this->debugInfoCookie = $value;
     }

Tests/UserInQueueStateCookieRepositoryTest.php

@@ -18,6 +18,16 @@ function __construct() {
     }
 
     public function setCookie($cookieName, $value, $expire, $domain, $isHttpOnly, $isSecure) {
+        if(is_null($value)){ $value = ""; }
+        
+        if(is_null($expire)){ $expire = 0; }
+        
+        if(is_null($domain)){ $domain = ""; }
+
+        if(is_null($isHttpOnly)){ $isHttpOnly = false; }
+    
+        if(is_null($isSecure)){ $isSecure = false; }
+
         $this->cookieList[$cookieName] = array(
             "name" => $cookieName,
             "value" => $value,

UserInQueueService.php

@@ -41,7 +41,7 @@ class UserInQueueService implements IUserInQueueService
 {
     public static function getSDKVersion()
     {
-        return "v3-php-" . "3.7.0";
+        return "v3-php-" . "3.7.1";
     }
 
     private $userInQueueStateRepository;