fix(typescript): don't treat ':' as annotation in 'x?++y:z'

Author: strager

docs/CHANGELOG.md

@@ -15,6 +15,8 @@ Semantic Versioning.
     falsely reports [E0185][] ("assignment to imported variable").
   * Interface index signature variables can now be named contextual keywords
     such as `type`.
+  * Writing `++x` inside `? :` no longer falsely reports [E0254][] ("unexpected
+    ':' in expression; did you mean 'as'?").
 
 ## 2.19.0 (2023-12-30)
 

src/quick-lint-js/fe/parse-expression.cpp

@@ -533,14 +533,15 @@ Expression* Parser::parse_primary_expression(Parse_Visitor_Base& v,
   case Token_Type::plus_plus: {
     Source_Code_Span operator_span = this->peek().span();
     this->skip();
-    Expression* child =
-        this->parse_expression(v, Precedence{
-                                      .binary_operators = false,
-                                      .math_or_logical_or_assignment = false,
-                                      .commas = false,
-                                      .in_operator = prec.in_operator,
-                                      .conditional_operator = false,
-                                  });
+    Expression* child = this->parse_expression(
+        v, Precedence{
+               .binary_operators = false,
+               .math_or_logical_or_assignment = false,
+               .commas = false,
+               .in_operator = prec.in_operator,
+               .colon_type_annotation = Allow_Type_Annotations::never,
+               .conditional_operator = false,
+           });
     if (child->kind() == Expression_Kind::Missing) {
       this->diag_reporter_->report(Diag_Missing_Operand_For_Operator{
           .where = operator_span,

test/test-parse-expression-typescript.cpp

@@ -90,6 +90,12 @@ TEST_F(Test_Parse_Expression_TypeScript,
     EXPECT_EQ(summarize(ast),
               "cond(var cond, paren(var t), paren(jsxelement(F)))");
   }
+
+  {
+    Test_Parser p(u8"cond ? ++t : f"_sv, typescript_jsx_options);
+    Expression* ast = p.parse_expression();
+    EXPECT_EQ(summarize(ast), "cond(var cond, rwunary(var t), var f)");
+  }
 }
 
 TEST_F(Test_Parse_Expression_TypeScript,