refactor(fe): remove special handling for keywords in JSX

As of the previous commit, we now always use skip_in_jsx() instead of
skip(), therefore we never see kw_as, etc. when parsing a JSX
attribute name.

Author: strager

src/quick-lint-js/fe/parse-expression.cpp

@@ -3818,13 +3818,13 @@ Expression* Parser::parse_jsx_element_or_fragment(Parse_Visitor_Base& v,
 
 next_attribute:
   switch (this->peek().type) {
-  // NOTE[JSX-keyword-after-TypeScript-generic]: Normally, JS/TS keywords would
-  // appear as Token_Type::identifier here. However, when parsing
-  // '<C<T> class="" />' in TypeScript, the 'class' following '>' is parsed as a
-  // keyword. This is because parse_and_visit_typescript_generic_arguments calls
-  // this->skip() rather than this->skip_in_jsx(). That's why we need to check
-  // for keywords here.
   QLJS_CASE_KEYWORD:
+    // JS/TS keywords should not happen here because skip_in_jsx() should have
+    // been called.
+    QLJS_ASSERT(false);
+    goto identifier_attribute_name;
+
+  identifier_attribute_name:
   case Token_Type::identifier: {
     Identifier attribute = this->peek().identifier_name();
     bool has_namespace = false;

test/test-parse-typescript-generic.cpp

@@ -910,7 +910,6 @@ TEST_F(Test_Parse_TypeScript_Generic, jsx_element) {
 
   {
     // 'as' should be treated as an attribute name, not a keyword.
-    // See NOTE[JSX-keyword-after-TypeScript-generic].
     Test_Parser p(u8"<C<T> as={value} />"_sv, typescript_jsx_options);
     Expression* ast = p.parse_expression();
     EXPECT_EQ(summarize(ast), "jsxelement(C, var value)");