Skip to content

Commit feebc03

Browse files
committed
Merge pull request #90 from guidomedina/master
No-op stores does nothing hence test class is not needed. (cherry picked from commit 9fbce5a)
1 parent fe683ee commit feebc03

File tree

3 files changed

+1
-47
lines changed

3 files changed

+1
-47
lines changed

quickfixj-core/src/main/java/quickfix/NoopStore.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@
2020

2121
package quickfix;
2222

23-
import org.slf4j.LoggerFactory;
24-
2523
import java.util.Collection;
2624
import java.util.Date;
2725

@@ -32,16 +30,10 @@
3230
*/
3331
public class NoopStore implements MessageStore {
3432

35-
private final SessionID sessionID;
36-
3733
private Date creationTime = new Date();
3834
private int nextSenderMsgSeqNum = 1;
3935
private int nextTargetMsgSeqNum = 1;
4036

41-
public NoopStore(SessionID sessionID) {
42-
this.sessionID = sessionID;
43-
}
44-
4537
public void get(int startSequence, int endSequence, Collection<String> messages) {
4638
}
4739

@@ -84,12 +76,5 @@ public void setNextTargetMsgSeqNum(int next) {
8476
}
8577

8678
public void refresh() {
87-
final String text = "No-op store does not support refresh!";
88-
if (sessionID != null) {
89-
final Session session = Session.lookupSession(sessionID);
90-
session.getLog().onErrorEvent("ERROR: " + text);
91-
} else {
92-
LoggerFactory.getLogger(NoopStore.class).error(text);
93-
}
9479
}
9580
}

quickfixj-core/src/main/java/quickfix/NoopStoreFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,6 @@ public final class NoopStoreFactory implements MessageStoreFactory {
2929

3030
@Override
3131
public MessageStore create(SessionID sessionID) {
32-
return new NoopStore(sessionID);
32+
return new NoopStore();
3333
}
3434
}

quickfixj-core/src/test/java/quickfix/NoopStoreTest.java

Lines changed: 0 additions & 31 deletions
This file was deleted.

0 commit comments

Comments
 (0)