Skip to content

Commit acd934d

Browse files
authored
Improve code quality (#197)
1 parent fd72319 commit acd934d

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

.github/workflows/Code-Quality.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ jobs:
3838
matrix:
3939
julia-version:
4040
- 'lts'
41+
- '1'
4142
os:
4243
- 'ubuntu-latest'
4344
arch:

src/evolution.jl

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,24 @@ A structure storing the results and some information from solving time evolution
1818
- `reltol::Real`: The relative tolerance which is used during the solving process.
1919
"""
2020
struct TimeEvolutionHEOMSol{
21-
TT1<:Vector{<:Real},
22-
TT2<:Vector{<:Real},
21+
TT1<:AbstractVector{<:Real},
22+
TT2<:AbstractVector{<:Real},
2323
TS<:Vector{ADOs},
24-
TE<:Union{Nothing,Matrix{ComplexF64}},
24+
TE<:Union{Nothing,AbstractMatrix},
25+
RETT<:Union{Nothing,Enum},
26+
AlgT<:Union{Nothing,OrdinaryDiffEqAlgorithm},
27+
TolT<:Union{Nothing,Real},
2528
}
2629
Btier::Int
2730
Ftier::Int
2831
times::TT1
2932
times_ados::TT2
3033
ados::TS
3134
expect::TE
32-
retcode::Union{Nothing,Enum}
33-
alg::Union{Nothing,OrdinaryDiffEqAlgorithm}
34-
abstol::Union{Nothing,Real}
35-
reltol::Union{Nothing,Real}
35+
retcode::RETT
36+
alg::AlgT
37+
abstol::TolT
38+
reltol::TolT
3639
end
3740

3841
function Base.show(io::IO, sol::TimeEvolutionHEOMSol)

test/code-quality/code_quality.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
@testset "Code quality" verbose = true begin
22
@testset "Aqua.jl" begin
3-
Aqua.test_all(HierarchicalEOM; ambiguities = false)
3+
Aqua.test_all(HierarchicalEOM; ambiguities = false, unbound_args = false)
44
end
55

66
@testset "JET.jl" begin

0 commit comments

Comments
 (0)