Skip to content

Commit 5fe906f

Browse files
icbakerSheenaChhabra
authored andcommitted
Rollback of androidx@e665e2a
PiperOrigin-RevId: 619871653 (cherry picked from commit b60cd2c)
1 parent 7b5522f commit 5fe906f

File tree

55 files changed

+72
-274
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+72
-274
lines changed

RELEASENOTES.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,12 @@
3030
from WAV files ([#1117](https://github.com/androidx/media/pull/1117)).
3131
* MP3: Populate `Format.averageBitrate` from metadata frames such as
3232
`XING` and `VBRI`.
33+
* MPEG-TS: Revert a change that aimed to ensure the last frame is rendered
34+
by passing the last access unit of a stream to the sample queue
35+
([#7909](https://github.com/google/ExoPlayer/issues/7909)). This is due
36+
to the change causing new problems with I-frame only HLS streams
37+
([#1150](https://github.com/google/ExoPlayer/issues/1150)) and H.262 HLS
38+
streams ([#1126](https://github.com/google/ExoPlayer/issues/1126)).
3339
* Audio:
3440
* Allow renderer recovery by disabling offload if audio track fails to
3541
initialize in offload mode.

libraries/extractor/src/main/java/androidx/media3/extractor/ts/Ac3Reader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ public void consume(ParsableByteArray data) {
159159
}
160160

161161
@Override
162-
public void packetFinished(boolean isEndOfInput) {
162+
public void packetFinished() {
163163
// Do nothing.
164164
}
165165

libraries/extractor/src/main/java/androidx/media3/extractor/ts/Ac4Reader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ public void consume(ParsableByteArray data) {
161161
}
162162

163163
@Override
164-
public void packetFinished(boolean isEndOfInput) {
164+
public void packetFinished() {
165165
// Do nothing.
166166
}
167167

libraries/extractor/src/main/java/androidx/media3/extractor/ts/AdtsReader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ public void consume(ParsableByteArray data) throws ParserException {
194194
}
195195

196196
@Override
197-
public void packetFinished(boolean isEndOfInput) {
197+
public void packetFinished() {
198198
// Do nothing.
199199
}
200200

libraries/extractor/src/main/java/androidx/media3/extractor/ts/DtsReader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ public void consume(ParsableByteArray data) throws ParserException {
215215
}
216216

217217
@Override
218-
public void packetFinished(boolean isEndOfInput) {
218+
public void packetFinished() {
219219
// Do nothing.
220220
}
221221

libraries/extractor/src/main/java/androidx/media3/extractor/ts/DvbSubtitleReader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public void packetStarted(long pesTimeUs, @TsPayloadReader.Flags int flags) {
8686
}
8787

8888
@Override
89-
public void packetFinished(boolean isEndOfInput) {
89+
public void packetFinished() {
9090
if (writingSample) {
9191
// packetStarted method must be called before reading sample.
9292
checkState(sampleTimeUs != C.TIME_UNSET);

libraries/extractor/src/main/java/androidx/media3/extractor/ts/ElementaryStreamReader.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
* <li>{@link #seek()} (optional, to reset the state)
3232
* <li>{@link #packetStarted(long, int)} (to signal the start of a new packet)
3333
* <li>{@link #consume(ParsableByteArray)} (zero or more times, to provide packet data)
34-
* <li>{@link #packetFinished(boolean)} (to signal the end of the current packet)
34+
* <li>{@link #packetFinished()} (to signal the end of the current packet)
3535
* <li>Repeat steps 3-5 for subsequent packets
3636
* </ol>
3737
*/
@@ -67,5 +67,5 @@ public interface ElementaryStreamReader {
6767
void consume(ParsableByteArray data) throws ParserException;
6868

6969
/** Called when a packet ends. */
70-
void packetFinished(boolean isEndOfInput);
70+
void packetFinished();
7171
}

libraries/extractor/src/main/java/androidx/media3/extractor/ts/H262Reader.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -217,13 +217,8 @@ public void consume(ParsableByteArray data) {
217217
}
218218

219219
@Override
220-
public void packetFinished(boolean isEndOfInput) {
221-
checkStateNotNull(output); // Asserts that createTracks has been called.
222-
if (isEndOfInput) {
223-
@C.BufferFlags int flags = sampleIsKeyframe ? C.BUFFER_FLAG_KEY_FRAME : 0;
224-
int size = (int) (totalBytesWritten - samplePosition);
225-
output.sampleMetadata(sampleTimeUs, flags, size, /* offset= */ 0, /* cryptoData= */ null);
226-
}
220+
public void packetFinished() {
221+
// Do nothing.
227222
}
228223

229224
/**

libraries/extractor/src/main/java/androidx/media3/extractor/ts/H263Reader.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -216,13 +216,8 @@ public void consume(ParsableByteArray data) {
216216
}
217217

218218
@Override
219-
public void packetFinished(boolean isEndOfInput) {
220-
// Assert that createTracks has been called.
221-
checkStateNotNull(sampleReader);
222-
if (isEndOfInput) {
223-
sampleReader.onDataEnd(totalBytesWritten, /* bytesWrittenPastPosition= */ 0, hasOutputFormat);
224-
sampleReader.reset();
225-
}
219+
public void packetFinished() {
220+
// Do nothing.
226221
}
227222

228223
/**

libraries/extractor/src/main/java/androidx/media3/extractor/ts/H264Reader.java

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -167,11 +167,8 @@ public void consume(ParsableByteArray data) {
167167
}
168168

169169
@Override
170-
public void packetFinished(boolean isEndOfInput) {
171-
assertTracksCreated();
172-
if (isEndOfInput) {
173-
sampleReader.end(totalBytesWritten);
174-
}
170+
public void packetFinished() {
171+
// Do nothing.
175172
}
176173

177174
@RequiresNonNull("sampleReader")
@@ -511,13 +508,6 @@ private void outputSample(int offset) {
511508
output.sampleMetadata(sampleTimeUs, flags, size, offset, null);
512509
}
513510

514-
public void end(long position) {
515-
// Output a final sample with the NAL units currently held
516-
nalUnitStartPosition = position;
517-
outputSample(/* offset= */ 0);
518-
readingSample = false;
519-
}
520-
521511
private static final class SliceHeaderData {
522512

523513
private static final int SLICE_TYPE_I = 2;

0 commit comments

Comments
 (0)