Activate subscription name validation

Section A.3.16 in the JMS 3.0 specification.

https://jakarta.ee/specifications/messaging/3.1/jakarta-messaging-spec-3.1.html#subscription-name-characters-and-length-2

Fixes #204

Author: acogoluegnes

src/main/java/com/rabbitmq/jms/admin/RMQConnectionFactory.java

@@ -240,14 +240,6 @@ public class RMQConnectionFactory implements ConnectionFactory, Referenceable, S
      */
     private boolean declareReplyToDestination = true;
 
-  /**
-   * Whether to validate subscription names or not, according to JMS 2.0. Default is false (no
-   * validation).
-   *
-   * @since 2.7.0
-   */
-  private boolean validateSubscriptionNames = false;
-
     /**
      * {@inheritDoc}
      */
@@ -328,7 +320,6 @@ protected Connection createConnection(String username, String password, Connecti
             .setTrustedPackages(this.trustedPackages)
             .setRequeueOnTimeout(this.requeueOnTimeout)
             .setKeepTextMessageType(this.keepTextMessageType)
-            .setValidateSubscriptionNames(this.validateSubscriptionNames)
         );
         logger.debug("Connection {} created.", conn);
         return conn;
@@ -1061,16 +1052,6 @@ public void setKeepTextMessageType(boolean keepTextMessageType) {
         this.keepTextMessageType = keepTextMessageType;
     }
 
-  /**
-   * Whether to validate subscription names or not, according to JMS 2.0. Default is false (no
-   * validation).
-   *
-   * @since 2.7.0
-   */
-  public void setValidateSubscriptionNames(boolean validateSubscriptionNames) {
-    this.validateSubscriptionNames = validateSubscriptionNames;
-  }
-
     @FunctionalInterface
     private interface ConnectionCreator {
         com.rabbitmq.client.Connection create(com.rabbitmq.client.ConnectionFactory cf) throws Exception;

src/main/java/com/rabbitmq/jms/client/ConnectionParams.java

@@ -110,8 +110,6 @@ public class ConnectionParams {
 
     private List<String> trustedPackages = WhiteListObjectInputStream.DEFAULT_TRUSTED_PACKAGES;
 
-    private boolean validateSubscriptionNames = false;
-
     public Connection getRabbitConnection() {
         return rabbitConnection;
     }
@@ -247,12 +245,4 @@ public boolean willRequeueOnTimeout() {
         return requeueOnTimeout;
     }
 
-    public ConnectionParams setValidateSubscriptionNames(boolean validateSubscriptionNames) {
-        this.validateSubscriptionNames = validateSubscriptionNames;
-        return this;
-    }
-
-    public boolean isValidateSubscriptionNames() {
-        return validateSubscriptionNames;
-    }
 }

src/main/java/com/rabbitmq/jms/client/RMQConnection.java

@@ -152,8 +152,6 @@ public class RMQConnection implements Connection, QueueConnection, TopicConnecti
 
     private final boolean keepTextMessageType;
 
-    private final boolean validateSubscriptionNames;
-
     /**
      * Creates an RMQConnection object.
      * @param connectionParams parameters for this connection
@@ -180,7 +178,6 @@ public RMQConnection(ConnectionParams connectionParams) {
         this.trustedPackages = connectionParams.getTrustedPackages();
         this.requeueOnTimeout = connectionParams.willRequeueOnTimeout();
         this.keepTextMessageType = connectionParams.isKeepTextMessageType();
-        this.validateSubscriptionNames = connectionParams.isValidateSubscriptionNames();
     }
 
     /**
@@ -236,7 +233,6 @@ public Session createSession(boolean transacted, int acknowledgeMode) throws JMS
             .setTrustedPackages(this.trustedPackages)
             .setRequeueOnTimeout(this.requeueOnTimeout)
             .setKeepTextMessageType(this.keepTextMessageType)
-            .setValidateSubscriptionNames(this.validateSubscriptionNames)
         );
         this.sessions.add(session);
         return session;

src/main/java/com/rabbitmq/jms/client/RMQSession.java

@@ -248,20 +248,16 @@ public RMQSession(SessionParams sessionParams) throws JMSException {
         this.trustedPackages = sessionParams.getTrustedPackages();
         this.requeueOnTimeout = sessionParams.willRequeueOnTimeout();
         this.keepTextMessageType = sessionParams.isKeepTextMessageType();
-        if (sessionParams.isValidateSubscriptionNames()) {
-            this.subscriptionNameValidator = name -> {
-                boolean subscriptionIsValid = Utils.SUBSCRIPTION_NAME_PREDICATE.test(name);
-                if (!subscriptionIsValid) {
-                    // the specification is not clear on which exception to throw when the
-                    // subscription name is not valid, so throwing a JMSException.
-                    throw new JMSException("This subscription name is not valid: " + name + ". "
-                        + "It must not be more than 128 characters and should contain only "
-                        + "Java letters, digits, '_', '.', and '-'.");
-                }
-            };
-        } else {
-            this.subscriptionNameValidator = name -> { };
-        }
+        this.subscriptionNameValidator = name -> {
+            boolean subscriptionIsValid = Utils.SUBSCRIPTION_NAME_PREDICATE.test(name);
+            if (!subscriptionIsValid) {
+                // the specification is not clear on which exception to throw when the
+                // subscription name is not valid, so throwing a JMSException.
+                throw new JMSException("This subscription name is not valid: " + name + ". "
+                    + "It must not be more than 128 characters and should contain only "
+                    + "Java letters, digits, '_', '.', and '-'.");
+            }
+        };
 
         if (transacted) {
             this.acknowledgeMode = Session.SESSION_TRANSACTED;

src/main/java/com/rabbitmq/jms/client/SessionParams.java

@@ -103,8 +103,6 @@ public class SessionParams {
 
     private boolean keepTextMessageType = false;
 
-    private boolean validateSubscriptionNames = false;
-
     private List<String> trustedPackages = WhiteListObjectInputStream.DEFAULT_TRUSTED_PACKAGES;
 
     public RMQConnection getConnection() {
@@ -242,12 +240,4 @@ public boolean willRequeueOnTimeout() {
         return requeueOnTimeout;
     }
 
-    public SessionParams setValidateSubscriptionNames(boolean validateSubscriptionNames) {
-        this.validateSubscriptionNames = validateSubscriptionNames;
-        return this;
-    }
-
-    public boolean isValidateSubscriptionNames() {
-        return validateSubscriptionNames;
-    }
 }

src/test/java/com/rabbitmq/integration/tests/SimpleDurableTopicMessageIT.java

@@ -44,7 +44,6 @@ public class SimpleDurableTopicMessageIT extends AbstractITTopic {
     @Override
     protected void customise(RMQConnectionFactory connectionFactory) {
        super.customise(connectionFactory);
-       connectionFactory.setValidateSubscriptionNames(true);
     }
 
     @Test