controller: fix the auto backup nfs error #740

acekingke · acekingke · commit 6dab2c585797 · 2022-11-10T16:29:28.000+08:00
diff --git a/controllers/backupcron_controller.go b/controllers/backupcron_controller.go
@@ -174,7 +174,9 @@ func (r *BackupCronReconciler) updateClusterSchedule(ctx context.Context, cluste
 		}
 	}
 	nfsServerAddress := ""
-	if BackupType == "nfs" {
+	// if has backupsecret and nfsServerAdrr, auto use nfs backup
+	// if you want s3 backup, set backupSecret only.
+	if BackupType != "s3" {
 		nfsServerAddress = cluster.Spec.NFSServerAddress
 	}
 	log.V(1).Info("register cluster in cronjob", "key", cluster.Name+BackupType, "schedule", schedule)

Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,9 @@ func (r *BackupCronReconciler) updateClusterSchedule(ctx context.Context, cluste`
`174`	`174`	`}`
`175`	`175`	`}`
`176`	`176`	`nfsServerAddress := ""`
`177`		`- if BackupType == "nfs" {`
	`177`	`+ // if has backupsecret and nfsServerAdrr, auto use nfs backup`
	`178`	`+ // if you want s3 backup, set backupSecret only.`
	`179`	`+ if BackupType != "s3" {`
`178`	`180`	`nfsServerAddress = cluster.Spec.NFSServerAddress`
`179`	`181`	`}`
`180`	`182`	`log.V(1).Info("register cluster in cronjob", "key", cluster.Name+BackupType, "schedule", schedule)`