Skip to content

Commit 7cbcb88

Browse files
authored
controllers: when name over 63, write error message in backup status … (#560)
controllers: when name over 63, write error message in backup status #553
1 parent 9519fdb commit 7cbcb88

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

controllers/backup_controller.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,13 @@ func (r *BackupReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
8585

8686
jobSyncer := backupSyncer.NewJobSyncer(r.Client, r.Scheme, backup)
8787
if err := syncer.Sync(ctx, jobSyncer, r.Recorder); err != nil {
88-
return reconcile.Result{}, err
88+
backup.UpdateStatusCondition(apiv1alpha1.BackupFailed, corev1.ConditionTrue, "CreateFailure", err.Error())
89+
backup.Status.Completed = true
90+
if err2 := r.updateBackup(savedBackup, backup); err2 != nil {
91+
return reconcile.Result{}, err2
92+
}
93+
// Do not try again.
94+
return reconcile.Result{}, nil
8995
}
9096

9197
if err = r.updateBackup(savedBackup, backup); err != nil {

0 commit comments

Comments
 (0)