Add message to event when job fails

brandond · brandond · commit 6ae0eb5d36a2 · 2025-06-24T09:02:18.000Z
Signed-off-by: Brad Davidson &lt;brad.davidson@rancher.com&gt;
diff --git a/pkg/upgrade/handle_batch.go b/pkg/upgrade/handle_batch.go
@@ -85,7 +85,7 @@ func (ctl *Controller) handleJobs(ctx context.Context) error {
 			if failedTime.IsZero() {
 				return obj, fmt.Errorf("condition %q missing field %q", upgradejob.ConditionFailed, "LastTransitionTime")
 			}
-			ctl.recorder.Eventf(plan, corev1.EventTypeWarning, "JobFailed", "Job failed on Node %s", node.Name)
+			ctl.recorder.Eventf(plan, corev1.EventTypeWarning, "JobFailed", "Job failed on Node %s: %s", node.Name, upgradejob.ConditionFailed.GetMessage(obj))
 			return obj, enqueueOrDelete(jobs, obj, failedTime)
 		}
 		// if the job has completed tag the node then enqueue-or-delete depending on the TTL window

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ func (ctl *Controller) handleJobs(ctx context.Context) error {`
`85`	`85`	`if failedTime.IsZero() {`
`86`	`86`	`return obj, fmt.Errorf("condition %q missing field %q", upgradejob.ConditionFailed, "LastTransitionTime")`
`87`	`87`	`}`
`88`		`- ctl.recorder.Eventf(plan, corev1.EventTypeWarning, "JobFailed", "Job failed on Node %s", node.Name)`
	`88`	`+ ctl.recorder.Eventf(plan, corev1.EventTypeWarning, "JobFailed", "Job failed on Node %s: %s", node.Name, upgradejob.ConditionFailed.GetMessage(obj))`
`89`	`89`	`return obj, enqueueOrDelete(jobs, obj, failedTime)`
`90`	`90`	`}`
`91`	`91`	`// if the job has completed tag the node then enqueue-or-delete depending on the TTL window`