Potential fixes

Signed-off-by: Michael Acar <michael.j.acar@gmail.com>

Author: mjacar

src/ray/raylet/worker_pool_test.cc

@@ -169,14 +169,17 @@ class WorkerPoolMock : public WorkerPool {
   using WorkerPool::PopWorkerCallbackInternal;
 
   // Mock `PopWorkerCallbackAsync` to synchronized function.
-  void PopWorkerCallbackAsync(PopWorkerCallback callback,
-                              std::shared_ptr<WorkerInterface> worker,
-                              PopWorkerStatus status = PopWorkerStatus::OK) override {
-    PopWorkerCallbackInternal(callback, worker, status);
+  void PopWorkerCallbackAsync(
+      PopWorkerCallback callback,
+      std::shared_ptr<WorkerInterface> worker,
+      PopWorkerStatus status,
+      const std::string &runtime_env_setup_error_message = "") override {
+    PopWorkerCallbackInternal(callback, worker, status, runtime_env_setup_error_message);
   }
 
   Process StartProcess(const std::vector<std::string> &worker_command_args,
-                       const ProcessEnvironment &env) override {
+                       const ProcessEnvironment &env,
+                       std::error_code &ec) override {
     // Use a bogus process ID that won't conflict with those in the system
     auto pid = static_cast<pid_t>(PID_MAX_LIMIT + 1 + worker_commands_by_proc_.size());
     last_worker_process_ = Process::FromPid(pid);

src/ray/util/process.cc

@@ -86,8 +86,9 @@ void SetFdCloseOnExec(int fd) {
 static inline ssize_t ReadBytesFromFd(int fd, void *buffer, size_t count) {
   ssize_t total_bytes_read = 0;
   while (total_bytes_read < (ssize_t)count) {
-    ssize_t bytes_read =
-        read(fd, (char *)buffer + total_bytes_read, count - total_bytes_read);
+    ssize_t bytes_read = read(fd,
+                              reinterpret_cast<char *>(buffer) + total_bytes_read,
+                              count - total_bytes_read);
     if (bytes_read == 0) {
       // EOF reached before all bytes were read.
       return total_bytes_read;
@@ -231,11 +232,9 @@ class ProcessFD {
       }
     }
 
-    if (!decouple) {
-      // This is the simple case for non-decoupled processes.
-      // Use a pipe with FD_CLOEXEC to synchronously report execvpe status.
-      SetFdCloseOnExec(pipefds[1]);
-    }
+    // Set the write-end of the pipe to close on exec. This is crucial for the parent
+    // to detect a successful execve, as the pipe will close automatically.
+    SetFdCloseOnExec(pipefds[1]);
 
     pid = fork();