Solution detection loads wrong .sln when multiple solutions exist in subfolders

[Adrianfss]

After upgrading from csharp-ls 0.18.0 to 0.19.0, I’m experiencing an issue with solution detection in a workspace that contains multiple .sln files in subfolders.

Setup:
• Root folder contains multiple subfolders, each with its own .sln
• ./a/a.sln
• ./b/b.sln
• I open a file inside ./b

Expected behavior (works in 0.18.0):
The language server should load the solution ./b/b.sln.

Actual behavior (broken in 0.19.0):
The language server instead tries to load ./a/a.sln.

Notes:
• This regression appeared after updating to 0.19.0.
• 0.18.0 handled the scenario correctly.

[razzmatazz]

There has been a slight change to the logic which decides which sln to load. I.e. it will now attempt to load the solution that has most of the projects (which may not make sense in your case, I recon).

The alternative is to specify the solution using the csharp.solution setting or the -s <sln> command line arg.

[razzmatazz]

It is in the plans to support multiple solutions and load them on-demand, so this issue would go away.