fix: return result of android dialog dismissal to JS (#636)

vonovak · web-flow · commit 98335f25dfd4 · 2022-07-25T23:55:40.000+02:00
diff --git a/src/DateTimePickerAndroid.android.js b/src/DateTimePickerAndroid.android.js
@@ -98,9 +98,9 @@ function open(props: AndroidNativeProps) {
   presentPicker();
 }
 
-function dismiss(mode: AndroidNativeProps['mode']) {
+function dismiss(mode: AndroidNativeProps['mode']): Promise<boolean> {
   // $FlowFixMe - `AbstractComponent` [1] is not an instance type.
-  pickers[mode].dismiss();
+  return pickers[mode].dismiss();
 }
 
 export const DateTimePickerAndroid = {open, dismiss};
diff --git a/src/index.d.ts b/src/index.d.ts
@@ -193,7 +193,7 @@ export type WindowsNativeProps = Readonly<
 
 declare namespace DateTimePickerAndroidType {
   const open: (args: AndroidNativeProps) => void;
-  const dismiss: (mode: AndroidNativeProps['mode']) => void;
+  const dismiss: (mode: AndroidNativeProps['mode']) => Promise<boolean>;
 }
 
 declare const RNDateTimePicker: FC<

Original file line number	Diff line number	Diff line change
`@@ -98,9 +98,9 @@ function open(props: AndroidNativeProps) {`
`98`	`98`	`presentPicker();`
`99`	`99`	`}`
`100`	`100`
`101`		`-function dismiss(mode: AndroidNativeProps['mode']) {`
	`101`	`+function dismiss(mode: AndroidNativeProps['mode']): Promise<boolean> {`
`102`	`102`	// $FlowFixMe - `AbstractComponent` [1] is not an instance type.
`103`		`- pickers[mode].dismiss();`
	`103`	`+ return pickers[mode].dismiss();`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`export const DateTimePickerAndroid = {open, dismiss};`
Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ export type WindowsNativeProps = Readonly<`
`193`	`193`
`194`	`194`	`declare namespace DateTimePickerAndroidType {`
`195`	`195`	`const open: (args: AndroidNativeProps) => void;`
`196`		`- const dismiss: (mode: AndroidNativeProps['mode']) => void;`
	`196`	`+ const dismiss: (mode: AndroidNativeProps['mode']) => Promise<boolean>;`
`197`	`197`	`}`
`198`	`198`
`199`	`199`	`declare const RNDateTimePicker: FC<`