Skip to content

Commit ffd3c47

Browse files
authored
Fix: Contrast issues on AccountSelectActivity on light themes, Closes #2048
1 parent a03079e commit ffd3c47

File tree

3 files changed

+17
-10
lines changed

3 files changed

+17
-10
lines changed

app/src/main/res/layout/account_list_item.xml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66
android:id="@+id/card_view"
77
android:layout_width="110dp"
88
android:layout_height="110dp"
9-
android:animateLayoutChanges="true"
10-
android:backgroundTint="?attr/primaryGrayBackground"
11-
android:foreground="?attr/selectableItemBackground"
129
android:layout_margin="10dp"
10+
android:animateLayoutChanges="true"
11+
android:backgroundTint="@color/primaryGrayBackground"
1312
android:focusable="true"
13+
android:foreground="?attr/selectableItemBackground"
1414
app:cardCornerRadius="@dimen/rounded_image_radius"
1515
app:layout_constraintBottom_toBottomOf="parent"
1616
app:layout_constraintDimensionRatio="1"
@@ -42,6 +42,7 @@
4242
android:layout_margin="4dp"
4343
android:src="@drawable/video_locked"
4444
android:visibility="gone"
45+
app:tint="@color/textColor"
4546
tools:visibility="visible" />
4647

4748
<TextView
@@ -51,6 +52,8 @@
5152
android:layout_gravity="center"
5253
android:gravity="center"
5354
android:padding="10dp"
54-
android:textSize="16sp" />
55+
android:textColor="@color/textColor"
56+
android:textSize="16sp"
57+
tools:text="Hello World!" />
5558

5659
</androidx.cardview.widget.CardView>

app/src/main/res/layout/account_list_item_edit.xml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66
android:id="@+id/card_view"
77
android:layout_width="110dp"
88
android:layout_height="110dp"
9-
android:animateLayoutChanges="true"
10-
android:backgroundTint="?attr/primaryGrayBackground"
11-
android:foreground="?attr/selectableItemBackground"
129
android:layout_margin="10dp"
10+
android:animateLayoutChanges="true"
11+
android:backgroundTint="@color/primaryGrayBackground"
1312
android:focusable="true"
13+
android:foreground="?attr/selectableItemBackground"
1414
app:cardCornerRadius="@dimen/rounded_image_radius"
1515
app:layout_constraintBottom_toBottomOf="parent"
1616
app:layout_constraintDimensionRatio="1"
@@ -42,14 +42,16 @@
4242
android:layout_margin="4dp"
4343
android:src="@drawable/video_locked"
4444
android:visibility="gone"
45+
app:tint="@color/textColor"
4546
tools:visibility="visible" />
4647

4748
<ImageView
4849
android:id="@+id/pencil_icon"
4950
android:layout_width="42dp"
5051
android:layout_height="42dp"
5152
android:layout_gravity="top|start"
52-
android:src="@drawable/ic_baseline_edit_24" />
53+
android:src="@drawable/ic_baseline_edit_24"
54+
app:tint="@color/textColor" />
5355

5456
<TextView
5557
android:id="@+id/account_name"
@@ -58,6 +60,8 @@
5860
android:layout_gravity="center"
5961
android:gravity="center"
6062
android:padding="10dp"
61-
android:textSize="16sp" />
63+
android:textColor="@color/textColor"
64+
android:textSize="16sp"
65+
tools:text="Hello World!" />
6266

6367
</androidx.cardview.widget.CardView>

app/src/main/res/layout/activity_account_select.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
android:layout_width="match_parent"
77
android:layout_height="match_parent">
88

9-
<ImageView
9+
<androidx.appcompat.widget.AppCompatImageView
1010
android:id="@+id/edit_account_button"
1111
android:layout_width="40dp"
1212
android:layout_height="40dp"

0 commit comments

Comments
 (0)