pr comments - get shift click working for links, remove extension comments

Author: zgavin1

src/components/ui/coaching-sessions/coaching-notes.tsx

@@ -115,6 +115,21 @@ const CoachingNotes = () => {
             class:
               "tiptap ProseMirror shadow appearance-none lg:min-h-[440px] sm:min-h-[200px] md:min-h-[350px] rounded w-full py-2 px-3 bg-inherit text-black dark:text-white text-sm mt-0 md:mt-3 leading-tight focus:outline-none focus:shadow-outline",
           },
+          handleDOMEvents: {
+            click: (view, event) => {
+              const target = event.target as HTMLElement;
+
+              // Check if the clicked element is an <a> tag and Shift is pressed
+              if (target.tagName === "A" && event.shiftKey) {
+                event.preventDefault(); // Prevent default link behavior
+                window
+                  .open(target.getAttribute("href") || "", "_blank")
+                  ?.focus();
+                return true; // Stop event propagation
+              }
+              return false; // Allow other handlers to process the event
+            },
+          },
         }}
         slotBefore={<Toolbar />}
       />

src/components/ui/coaching-sessions/coaching-notes/extended-link-extension.tsx

@@ -36,34 +36,6 @@ export const ConfiguredLink = LinkWithTitle.configure({
         return false;
       }
 
-      // Placeholder for future disallowed domains if we want to add any
-      // const disallowedProtocols = ["ftp", "file", "mailto"];
-      // const protocol = parsedUrl.protocol.replace(":", "");
-
-      // if (disallowedProtocols.includes(protocol)) {
-      //   return false;
-      // }
-
-      // // only allow protocols specified in ctx.protocols
-      // const allowedProtocols = ctx.protocols.map((p) =>
-      //   typeof p === "string" ? p : p.scheme
-      // );
-
-      // if (!allowedProtocols.includes(protocol)) {
-      //   return false;
-      // }
-
-      // Placeholder for future disallowed domains if we want to add any
-      // const disallowedDomains = [
-      //   "example-phishing.com",
-      //   "malicious-site.net",
-      // ];
-      // const domain = parsedUrl.hostname;
-
-      // if (disallowedDomains.includes(domain)) {
-      //   return false;
-      // }
-
       // all checks have passed
       return true;
     } catch {
@@ -77,14 +49,7 @@ export const ConfiguredLink = LinkWithTitle.configure({
         ? new URL(url)
         : new URL(`https://${url}`);
 
-      // only auto-link if the domain is not in the disallowed list
-      const disallowedDomains = [
-        "example-no-autolink.com",
-        "another-no-autolink.com",
-      ];
-      const domain = parsedUrl.hostname;
-
-      return !disallowedDomains.includes(domain);
+      return !!parsedUrl;
     } catch {
       return false;
     }

src/components/ui/coaching-sessions/coaching-notes/extensions.tsx

@@ -11,7 +11,6 @@ import Paragraph from "@tiptap/extension-paragraph";
 import Strike from "@tiptap/extension-strike";
 import Text from "@tiptap/extension-text";
 import Underline from "@tiptap/extension-underline";
-import Link from "@tiptap/extension-link";
 import Collaboration from "@tiptap/extension-collaboration";
 import { ReactNodeViewRenderer } from "@tiptap/react";
 import CodeBlock from "@/components/ui/coaching-sessions/code-block";

src/components/ui/coaching-sessions/coaching-notes/toolbar.tsx

@@ -119,8 +119,8 @@ export const Toolbar = () => {
           icon={<Link className="h-4 w-4" />}
           title={
             editor.isActive("link")
-              ? "Update link (Ctrl + k)"
-              : "Insert link (Ctrl + k)"
+              ? "Update Link (Ctrl + k)"
+              : "Insert Link (Ctrl + k)"
           }
         />
       </div>