address review comments

Author: calebbourg

package-lock.json

@@ -66,7 +66,7 @@ export default function MembersPage({
 
   return (
     <div className="container mx-auto p-6 space-y-8">
-      <h1 className="text-3xl font-bold">Members</h1>
+      <h3 className="text-3xl font-bold">Members</h3>
       <MemberContainer
         users={users}
         relationships={relationships}

src/app/organizations/[id]/members/page.tsx

@@ -6,12 +6,13 @@ import { Trash2 } from "lucide-react";
 import { CoachingRelationshipWithUserNames } from "@/types/coaching_relationship_with_user_names";
 import { OrganizationStateStore } from "@/lib/stores/organization-state-store";
 import { AuthStore } from "@/lib/stores/auth-store";
+import { Id } from "@/types/general";
 
 interface MemberCardProps {
   firstName: string;
   lastName: string;
-  email?: string;
-  userId: string;
+  email: string;
+  userId: Id;
   userRelationships: CoachingRelationshipWithUserNames[];
   onRefresh: () => void;
 }
@@ -43,10 +44,10 @@ export function MemberCard({
 
     try {
       await deleteUser(currentOrganizationId, userId);
-      onRefresh(); // Call refresh after successful deletion
+      onRefresh();
     } catch (error) {
       console.error("Error deleting user:", error);
-      // You might want to show an error toast here
+      // TODO: Show an error toast here once we start using toasts for showing operation results.
     }
   };
 

src/components/ui/members/member-card.tsx

@@ -52,7 +52,6 @@ export function MemberContainer({
   return (
     <div className="space-y-6">
       <div className="flex justify-between items-center">
-        <h2 className="text-2xl font-semibold">Members</h2>
         {/* Only show the button if user is a coach to _some_ user within the
         scope of the organization. We may come back and add this directly to user
         data.  */}

src/components/ui/members/member-container.tsx

@@ -2,6 +2,7 @@ import { Card, CardContent } from "@/components/ui/card";
 import { User } from "@/types/user";
 import { MemberCard } from "./member-card";
 import { CoachingRelationshipWithUserNames } from "@/types/coaching_relationship_with_user_names";
+import { Id } from "@/types/general";
 
 interface MemberListProps {
   users: User[];
@@ -15,12 +16,12 @@ export function MemberList({
   onRefresh,
 }: MemberListProps) {
   // Create a mapping of user IDs to their associated relationships
-  const userRelationshipsMap = users.reduce((acc, user) => {
-    acc[user.id] = relationships.filter(
+  const userRelationshipsMap = users.reduce((accumulator_map, user) => {
+    accumulator_map[user.id] = relationships.filter(
       (rel) => rel.coach_id === user.id || rel.coachee_id === user.id
     );
-    return acc;
-  }, {} as Record<string, CoachingRelationshipWithUserNames[]>);
+    return accumulator_map;
+  }, {} as Record<Id, CoachingRelationshipWithUserNames[]>);
 
   return (
     <Card className="w-full">

src/components/ui/members/member-list.tsx

@@ -73,7 +73,7 @@ export const ActionApi = {
    * @param actionId The ID of the action to delete
    * @returns Promise resolving to the deleted Action object
    */
-  deleteNested: async (entityId: Id, actionId: Id): Promise<Action> => {
+  deleteNested: async (_entityId: Id, _actionId: Id): Promise<Action> => {
     throw new Error("Delete nested operation not implemented");
   },
 };

src/lib/api/actions.ts

@@ -77,7 +77,7 @@ export const AgreementApi = {
    * @param agreementId The ID of the agreement to delete
    * @returns Promise resolving to the deleted Agreement object
    */
-  deleteNested: async (entityId: Id, agreementId: Id): Promise<Agreement> => {
+  deleteNested: async (_entityId: Id, agreementId: Id): Promise<Agreement> => {
     throw new Error("Delete nested operation not implemented");
   },
 };

src/lib/api/agreements.ts

@@ -100,8 +100,8 @@ export const CoachingRelationshipApi = {
    * @returns Promise resolving to the deleted CoachingRelationshipWithUserNames object
    */
   deleteNested: async (
-    organizationId: Id,
-    relationshipId: Id
+    _organizationId: Id,
+    _relationshipId: Id
   ): Promise<CoachingRelationshipWithUserNames> => {
     throw new Error("Delete nested operation not implemented");
   },

src/lib/api/coaching-relationships.ts

@@ -104,7 +104,7 @@ export const CoachingSessionApi = {
    * @returns Promise resolving to the deleted CoachingSession object
    */
   deleteNested: async (
-    entityId: Id,
+    _entityId: Id,
     coachingSessionId: Id
   ): Promise<CoachingSession> => {
     throw new Error("Delete nested operation not implemented");

src/lib/api/coaching-sessions.ts

@@ -193,7 +193,6 @@ export namespace EntityApi {
     url: string,
     config?: any
   ): Promise<R> => {
-    console.log("deleteFn", url, config);
     return mutationFn<T, R>("delete", url, config);
   };