-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor other entity API functions and hooks to use new pattern #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
7c9ce87
Change OrganizationAPI to proper camel-case.
jhodapp f9475ef
Refactor the Coaching Relationships API to use the new function/hook …
jhodapp f6aa87e
Update function documentation.
jhodapp 1b4d63a
Refactor the OverarchingGoal API to use the new function/hook pattern.
jhodapp e520cc2
add CollaborationCursor
calebbourg 4afa804
add more console logging and check for existing provider
calebbourg 900fe9a
Get collab cursor working
zgavin1 d15a6d1
Update entity-api to include an optional response data parsing/transf…
jhodapp 5d2f4f8
Update Agreements to use new EntityApi functions/hooks.
jhodapp 26eabe5
Remove the parseAgreement() function that is replaced by the transfor…
jhodapp 9abbadf
Refactor Actions to use the new API/hook pattern. Also move the new t…
jhodapp 305ca0e
Create an ORGANIZATIONS_BASEURL const like the other entities have an…
jhodapp ff19326
Refactor coaching sessions to use the new API/Hook pattern.
jhodapp dadf69b
Refactor user session login/logout functions to use new hook/API patt…
jhodapp 1088d2b
Factor out the repititous URL strings for coaching relationships
jhodapp e5c6c7b
Remove parsing function for the coaching relationship with user names…
jhodapp c74c9c7
Improve the loading/error message of the CoachingNotes component.
jhodapp f2409bd
Fix non-escaped text build error.
jhodapp bea8419
Add missing function documentation for createNested() hook mutation.
jhodapp 85730c7
Set error state with message rather than with error object
zgavin1 5f395ce
Merge branch 'refactor_other_entity_apis_and_hooks' into issue-81-fix…
jhodapp fb7ce05
Merge pull request #82 from refactor-group/issue-81-fix-auth-error-ha…
jhodapp 50e2c28
Address review comments, fetcher config as non-optional and remove us…
jhodapp 9af2ac4
Merge branch 'main' into refactor_other_entity_apis_and_hooks
jhodapp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component and others should ideally be updated to use hooks instead of the direct function calls, but I decided it was out of the scope of this PR to refactor to this level since it would be a pretty major component code restructuring change.
The main reason being, this will give us automatic updates of list of entities when they're changed locally by the current user without having to refresh the page. For example, in the CoachingSessionList component.