fix: refactor with suggested changes

Author: berkinanik

zod/app/routes/index.tsx

@@ -1,4 +1,5 @@
-import { ActionArgs, json } from "@remix-run/node";
+import type { ActionArgs } from "@remix-run/node";
+import { json } from "@remix-run/node";
 import { Form, Link, useActionData, useNavigation } from "@remix-run/react";
 import * as z from "zod";
 
@@ -108,13 +109,11 @@ export default function RegisterView() {
             name="firstName"
             defaultValue={actionData?.fields?.firstName}
           />
-          {actionData?.fieldErrors?.firstName
-            ? actionData.fieldErrors.firstName.map((error, index) => (
-                <p style={errorTextStyle} key={`first-name-error-${index}`}>
-                  {error}
-                </p>
-              ))
-            : null}
+          {actionData?.fieldErrors?.firstName?.map((error, index) => (
+            <p style={errorTextStyle} key={`first-name-error-${index}`}>
+              {error}
+            </p>
+          ))}
         </div>
 
         <br />
@@ -127,13 +126,11 @@ export default function RegisterView() {
             name="email"
             defaultValue={actionData?.fields?.email}
           />
-          {actionData?.fieldErrors?.email
-            ? actionData.fieldErrors.email.map((error, index) => (
-                <p style={errorTextStyle} key={`email-error-${index}`}>
-                  {error}
-                </p>
-              ))
-            : null}
+          {actionData?.fieldErrors?.email?.map((error, index) => (
+            <p style={errorTextStyle} key={`email-error-${index}`}>
+              {error}
+            </p>
+          ))}
         </div>
 
         <br />
@@ -146,13 +143,11 @@ export default function RegisterView() {
             name="birthday"
             defaultValue={actionData?.fields?.birthday}
           />
-          {actionData?.fieldErrors?.birthday
-            ? actionData.fieldErrors.birthday.map((error, index) => (
-                <p style={errorTextStyle} key={`birthday-error-${index}`}>
-                  {error}
-                </p>
-              ))
-            : null}
+          {actionData?.fieldErrors?.birthday?.map((error, index) => (
+            <p style={errorTextStyle} key={`birthday-error-${index}`}>
+              {error}
+            </p>
+          ))}
         </div>
 
         <br />

zod/app/routes/products.tsx

@@ -1,4 +1,5 @@
-import { LoaderArgs, json, redirect } from "@remix-run/node";
+import type { LoaderArgs } from "@remix-run/node";
+import { json, redirect } from "@remix-run/node";
 import {
   Form,
   Link,
@@ -11,7 +12,7 @@ import * as z from "zod";
 import { mockProducts } from "~/lib/product.server";
 
 export const loader = ({ request }: LoaderArgs) => {
-  const URLSearchParams = new URL(request.url).searchParams;
+  const { searchParams } = new URL(request.url);
 
   const schema = z.object({
     name: z.string().optional(),
@@ -24,9 +25,7 @@ export const loader = ({ request }: LoaderArgs) => {
   // filter out empty string values from query params
   // otherwise zod will throw while coercing them to number
   const parseResult = schema.safeParse(
-    Object.fromEntries(
-      [...URLSearchParams.entries()].filter(([, v]) => v !== ""),
-    ),
+    Object.fromEntries([...searchParams.entries()].filter(([, v]) => v !== "")),
   );
 
   if (!parseResult.success) {
@@ -67,8 +66,8 @@ export const loader = ({ request }: LoaderArgs) => {
 
   if (pagination.page > totalPageCount) {
     // reset page to 1 and redirect on invalid page number
-    URLSearchParams.set("page", "1");
-    return redirect(`?${URLSearchParams.toString()}`, {
+    searchParams.set("page", "1");
+    return redirect(`?${searchParams.toString()}`, {
       status: 303,
     });
   }