Skip to content

🐞 Bug RemoveComments + CollapseWhitespace - Correctly handle // JS comments #188

@Rikj000

Description

@Rikj000

Detailed description

Currently the RemoveComments,
and thus also CollapseWhitespace middlewares don't correctly strip out // Comments from JavaScript <script> tags.

Context

The described issue leads to broken compressed pages due to JavaScript code being // Commented out.

This also leads to confusion with developers trying to implement this package,
some might abandon the package, thinking it is broken while it is not.

Work Around

Replace all your JavaScript // Comments with <!-- Comment -->s

Your environment

Software Version
PHP v8.1.27
Laravel v10.43.0
Laravel-Page-Speed dev-master b16c018

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions