Don't filter out module-related type errors (#1090)

* Don't filter out module-related type errors

* Add CHANGELOG

Author: mediremi

CHANGELOG.md

@@ -14,6 +14,8 @@
 
 #### :bug: Bug fix
 
+- Fix: bug where we incorrectly showed a warning notification about something going wrong with incremental type checking, when in fact the compiler was reporting module-related type errors https://github.com/rescript-lang/rescript-vscode/pull/1090
+
 - Fix: bug where we incorrectly showed a warning notification about something going wrong with incremental type checking, when in fact the compiler was reporting multiple definitions of the same type or module name https://github.com/rescript-lang/rescript-vscode/pull/1086
 
 - Fix: incorrect highlighting of `as` inside labelled arguments like `toast` https://github.com/rescript-lang/rescript-vscode/pull/1085

server/src/incrementalCompilation.ts

@@ -683,7 +683,12 @@ async function compileContents(
                   ) ||
                   // The `Multiple definition of the <kind> name <name>` type error's
                   // message includes the filepath with LOC of the duplicate definition
-                  d.message.includes("Multiple definition of the")
+                  d.message.startsWith("Multiple definition of the") ||
+                  // The signature mismatch, with mismatch and ill typed applicative functor
+                  // type errors all include the filepath with LOC
+                  d.message.startsWith("Signature mismatch") ||
+                  d.message.startsWith("In this `with' constraint") ||
+                  d.message.startsWith("This `with' constraint on")
                 )
               ) {
                 hasIgnoredErrorMessages = true;