Clean up doc tests script, use array helpers instead of AsyncIterator

Author: cknitt

.github/workflows/ci.yml

@@ -132,7 +132,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
-            # Default is too slow, 256
+          # Default is too slow, 256
       - name: Increase file descriptors limit (macOS only)
         if: runner.os == 'macOS'
         run: sudo launchctl limit maxfiles 6000 10000
@@ -257,7 +257,7 @@ jobs:
       - name: "Windows: set SHELLOPTS=igncr"
         if: runner.os == 'Windows'
         run: echo "SHELLOPTS=igncr" >>"$GITHUB_ENV"
-          
+
       - name: Build compiler
         if: runner.os != 'Linux'
         run: opam exec -- dune build --display quiet --profile release
@@ -326,11 +326,8 @@ jobs:
       - name: Run tests
         run: node scripts/test.js -all
 
-      - name: Docstrins tests
-        if: runner.os == 'macOS'
-        env:
-          UV_THREADPOOL_SIZE: 8
-        run: node tests/docstrings_examples/DocTest.res.mjs --ignore-runtime-tests "Array.toReversed, Array.toSorted, Promise.withResolvers, Set.union, Set.isSupersetOf, Set.isSubsetOf, Set.isDisjointFrom, Set.intersection, Set.symmetricDifference, Set.difference"
+      - name: Docstrings tests
+        run: node tests/docstrings_examples/DocTest.res.mjs
 
       - name: Check for diffs in tests folder
         run: git diff --ignore-cr-at-eol --exit-code tests
@@ -353,7 +350,7 @@ jobs:
         with:
           path: ./tests/benchmark-cache
           key: syntax-benchmark-v1
- 
+
       - name: Create new benchmark data and comment on alert
         # Do not run for PRs created from other repos as those won't be able to write to the pull request
         if: ${{ matrix.benchmarks && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.event.repository.full_name) }}
@@ -374,7 +371,7 @@ jobs:
         with:
           path: ./tests/benchmark-cache
           key: syntax-benchmark-v1
-     
+
       - name: Build playground compiler
         if: matrix.build_playground
         run: |
@@ -411,7 +408,7 @@ jobs:
     needs:
       - build-compiler
       - build-rewatch
-  
+
     runs-on: ubuntu-latest
 
     steps:

scripts/test.js

@@ -138,7 +138,7 @@ async function runTests() {
       });
       // Ignore some tests not supported by node v18
       // cp.execSync(
-      //   `node ${path.join("tests", "docstrings_examples", "DocTest.res.mjs")} --ignore-runtime-tests "Array.toReversed, Array.toSorted, Promise.withResolvers, Set.union, Set.isSupersetOf, Set.isSubsetOf, Set.isDisjointFrom, Set.intersection, Set.symmetricDifference, Set.difference"`,
+      //   `node ${path.join("tests", "docstrings_examples", "DocTest.res.mjs")}"`,
       //   {
       //     cwd: path.join(__dirname, ".."),
       //     stdio: [0, 1, 2],

tests/docstrings_examples/ArrayUtils.res

@@ -0,0 +1,29 @@
+let splitIntoChunks = (arr, ~chunkSize) => {
+  let chunks = []
+  let length = arr->Array.length
+  let startRef = ref(0)
+
+  while startRef.contents < length {
+    let end = startRef.contents + chunkSize
+    let chunk = arr->Array.slice(~start=startRef.contents, ~end)
+
+    chunks->Array.push(chunk)
+    startRef := end
+  }
+
+  chunks
+}
+
+let forEachAsyncParallel = async (arr, f) => {
+  let _: array<unit> = await Promise.all(arr->Array.map(f))
+}
+
+let forEachAsyncSerially = async (arr, f) =>
+  for i in 0 to arr->Array.length - 1 {
+    await f(arr->Array.getUnsafe(i))
+  }
+
+let forEachAsyncInBatches = (arr, ~batchSize, f) =>
+  arr
+  ->splitIntoChunks(~chunkSize=batchSize)
+  ->forEachAsyncSerially(chunk => chunk->forEachAsyncParallel(f))

tests/docstrings_examples/ArrayUtils.res.mjs

@@ -0,0 +1,37 @@
+// Generated by ReScript, PLEASE EDIT WITH CARE
+
+
+function splitIntoChunks(arr, chunkSize) {
+  let chunks = [];
+  let length = arr.length;
+  let startRef = 0;
+  while (startRef < length) {
+    let end = startRef + chunkSize | 0;
+    let chunk = arr.slice(startRef, end);
+    chunks.push(chunk);
+    startRef = end;
+  };
+  return chunks;
+}
+
+async function forEachAsyncParallel(arr, f) {
+  await Promise.all(arr.map(f));
+}
+
+async function forEachAsyncSerially(arr, f) {
+  for (let i = 0, i_finish = arr.length; i < i_finish; ++i) {
+    await f(arr[i]);
+  }
+}
+
+function forEachAsyncInBatches(arr, batchSize, f) {
+  return forEachAsyncSerially(splitIntoChunks(arr, batchSize), chunk => forEachAsyncParallel(chunk, f));
+}
+
+export {
+  splitIntoChunks,
+  forEachAsyncParallel,
+  forEachAsyncSerially,
+  forEachAsyncInBatches,
+}
+/* No side effect */