Fixes some static analysis issues

Author: richan-fongdasen

.github/workflows/main.yml

@@ -2,49 +2,34 @@ name: Build
 
 on:
   push:
-    paths-ignore:
-      - *.md
+    paths-ignore: ["*.md"]
   pull_request:
-    paths-ignore:
-      - *.md
-    branches:
-      - main
+    paths-ignore: ["*.md"]
+    branches: [main]
 
 jobs:
   analysis:
-
-
     runs-on: ubuntu-latest
 
-
-
     strategy:
       matrix:
-        php: ['8.2', 8.3, '8.3', '8.4']
-
-
+        php: [8.3]
 
     steps:
       - uses: actions/checkout@v4
 
-
-
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php }}
           extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, bcmath, intl, gd, exif, iconv
           coverage: none
 
-
-
       - name: Get Composer Cache Directory
         id: composer-cache
         run: |
           echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
 
-
-
       - name: Cache composer dependencies
         uses: actions/cache@v4
         env:
@@ -55,61 +40,42 @@ jobs:
           restore-keys: |
             php-${{ matrix.php }}-build-${{ env.cache-name }}-
 
-
-
       - name: Install composer dependencies
         run: composer install --prefer-dist
 
-
-
       - name: Run phpstan analysis
         run: composer phpstan-analysis
 
-
-
       - name: Run phpmd analysis
         run: composer phpmd-analysis
 
   test:
     name: Test (PHP ${{ matrix.php }})
 
-
-    needs:
-      - analysis
-
+    needs: [analysis]
 
     runs-on: ubuntu-latest
 
-
-
     strategy:
       matrix:
-        php: [8.0, 8.1, 8.2]
-
-
+        php: [8.0, 8.1, 8.2, 8.3, 8.4]
 
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
 
-
-
       - name: Set up PHP
         uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php }}
           extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, bcmath, intl, gd, exif, iconv
           coverage: none
 
-
-
       - name: Get Composer Cache Directory
         id: composer-cache
         run: |
           echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
 
-
-
       - name: Cache composer dependencies
         uses: actions/cache@v4
         env:
@@ -120,75 +86,53 @@ jobs:
           restore-keys: |
             php-${{ matrix.php }}-build-${{ env.cache-name }}-
 
-
-
       - name: Install composer dependencies
         run: composer install --no-interaction --prefer-dist
 
-
-
       - name: Run PHPUnit tests
         run: vendor/bin/phpunit
 
   test-coverage:
     name: Test (PHP ${{ matrix.php }})
 
-
-    needs:
-      - analysis
-
+    needs: [analysis]
 
     runs-on: ubuntu-latest
 
-
-
     strategy:
       matrix:
-        php: ['8.2', 8.3, '8.3', '8.4']
-
-
+        php: [8.3]
 
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
 
-
-
       - name: Set up PHP
         uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php }}
           extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, bcmath, intl, gd, exif, iconv
 
-
-
       - name: Get Composer Cache Directory
         id: composer-cache
         run: |
           echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
 
-
-
       - name: Cache composer dependencies
         uses: actions/cache@v4
         env:
           cache-name: laravel-i18n-test
         with:
           path: ${{ steps.composer-cache.outputs.dir }}
           key: php-${{ matrix.php }}-build-${{ env.cache-name }}-${{ hashFiles('**/composer.json') }}
-          restore-keys: php-${{ matrix.php }}-build-${{ env.cache-name }}-
-
-
+          restore-keys: |
+            php-${{ matrix.php }}-build-${{ env.cache-name }}-
 
       - name: Install composer dependencies
         run: composer install --no-interaction --prefer-dist
 
-
-
       - name: Run PHPUnit tests and generate code coverage
         run: vendor/bin/phpunit --coverage-clover=clover.xml
 
-
-
       - name: Upload code coverage results
         run: bash <(curl -s https://codecov.io/bash)

composer.json

@@ -30,13 +30,13 @@
         "php": "^8.0",
         "illuminate/database": "^8.0|^9.0|^10.0|^11.0|^12.0",
         "illuminate/support": "^8.0|^9.0|^10.0|^11.0|^12.0",
-        "nesbot/carbon": "^2.16|^3.0"
+        "nesbot/carbon": "^2.16|^3.8.4"
     },
     "require-dev": {
         "ekino/phpstan-banned-code": "^1.0|^3.0",
         "fakerphp/faker": "^1.9",
         "mockery/mockery": "^1.4",
-        "larastan/larastan": "^1.0|^2.0",
+        "larastan/larastan": "^1.0|^2.0|^3.0",
         "orchestra/testbench": "^6.0|^7.0|^8.0|^9.0|^10.0",
         "phpmd/phpmd": "^2.11",
         "phpstan/phpstan-deprecation-rules": "^1.0|^2.0",

phpstan.neon

@@ -6,12 +6,12 @@ includes:
 
 parameters:
     level: 8
-    checkMissingIterableValueType: false
-    checkGenericClassInNonGenericObjectType: false
     paths:
         - src
     ignoreErrors:
-        - '#Call to an undefined method RichanFongdasen\\I18n\\ServiceProvider::each\(\).#'
+        - identifier: missingType.iterableValue
+        - identifier: missingType.generics
+        - identifier: trait.unused
     banned_code:
         nodes:
             - type: Expr_FuncCall

src/Eloquent/Models/Language.php

@@ -21,7 +21,7 @@ class Language extends Model
     /**
      * The attributes that are mass assignable.
      *
-     * @var array<int, string>
+     * @var list<string>
      */
     protected $fillable = [
         'name',