Review Change and improvements

Author: SushilMallRC

src/components/admin/managedSettings/activityLoggingSettingPage.js

@@ -48,7 +48,7 @@ function getActivityLoggingSettingPageRender({ adminUserSettings, crmManifest, u
                 },
                 logSyncFrequencySection: {
                     type: 'object',
-                    title: 'Log sync frequency',
+                    title: 'Call Log Sync Frequency',
                     properties: {
                         logSyncFrequency: {
                             type: 'object',

src/components/admin/managedSettings/customSettingsPage.js

@@ -23,9 +23,9 @@ function getCustomSettingsPageRender({ crmManifest, adminUserSettings, userSetti
     }
     for (const section of crmManifest.settings) {
         // Skip sections that should appear in Activity logging admin page
-        if (section.section === 'activityLogging') {
-            continue;
-        }
+        // if (section.section === 'activityLogging') {
+        //     continue;
+        // }
 
         page.schema.properties[section.id] = {
             type: 'string',

src/core/user.js

@@ -97,7 +97,7 @@ async function refreshUserSettings({ changedSettings, isAvoidForceChange = false
         recordings: getShowRecordingsTabSetting(userSettings).value,
         contacts: getShowContactsTabSetting(userSettings).value
     }, '*');
-    const autoLogMessagesGroupTrigger = (userSettings?.autoLogSMS?.value ?? false) || (userSettings?.autoLogInboundFax?.value ?? false) || (userSettings?.autoLogOutboundFax?.value ?? false);
+    const autoLogMessagesGroupTrigger = (userSettings?.autoLogSMS?.value ?? false) || (userSettings?.autoLogInboundFax?.value ?? false) || (userSettings?.autoLogOutboundFax?.value ?? false) || (userSettings?.autoLogVoicemails?.value ?? false);
     const autoLogCallsGroupTrigger = (userSettings?.autoLogAnsweredIncoming?.value ?? false) || (userSettings?.autoLogMissedIncoming?.value ?? false) || (userSettings?.autoLogOutgoing?.value ?? false);
     RCAdapter.setAutoLog({ call: autoLogCallsGroupTrigger || (userSettings.autoLogCall?.value ?? false), message: autoLogMessagesGroupTrigger })
     if (!isAvoidForceChange) {

src/popup.js

@@ -77,6 +77,52 @@ let platform = null;
 let hasOngoingCall = false;
 let lastUserSettingSyncDate = new Date();
 
+// Helper function to determine if a call should be auto-logged based on direction and result
+function shouldAutoLogCall(call, userSettings) {
+  let shouldAutoLog = false;
+
+  if (call.direction === 'Inbound') {
+    if (call.result === 'Answered') {
+      shouldAutoLog = userSettings?.autoLogAnsweredIncoming?.value ?? false;
+    } else if (call.result === 'Missed') {
+      shouldAutoLog = userSettings?.autoLogMissedIncoming?.value ?? false;
+    }
+  } else if (call.direction === 'Outbound') {
+    shouldAutoLog = userSettings?.autoLogOutgoing?.value ?? false;
+  }
+
+  // Fallback to legacy setting for backward compatibility
+  if (!shouldAutoLog) {
+    shouldAutoLog = userSettings?.autoLogCall?.value ?? false;
+  }
+
+  return shouldAutoLog;
+}
+
+// Helper function for presence update auto-logging (maps presence results to call results)
+function shouldAutoLogCallFromPresence(call, userSettings) {
+  let shouldAutoLog = false;
+
+  if (call.direction === 'Inbound') {
+    // For inbound calls: CallConnected = answered, Disconnected = missed
+    if (call.result === 'CallConnected') {
+      shouldAutoLog = userSettings?.autoLogAnsweredIncoming?.value ?? false;
+    } else if (call.result === 'Disconnected') {
+      shouldAutoLog = userSettings?.autoLogMissedIncoming?.value ?? false;
+    }
+  } else if (call.direction === 'Outbound') {
+    // For outbound calls: both CallConnected and Disconnected mean call was made
+    shouldAutoLog = userSettings?.autoLogOutgoing?.value ?? false;
+  }
+
+  // Fallback to legacy setting for backward compatibility
+  if (!shouldAutoLog) {
+    shouldAutoLog = userSettings?.autoLogCall?.value ?? false;
+  }
+
+  return shouldAutoLog;
+}
+
 async function restartSyncInterval() {
   // Clear existing interval
   const { retroAutoCallLogIntervalId } = await chrome.storage.local.get({ retroAutoCallLogIntervalId: null });
@@ -1273,16 +1319,23 @@ window.addEventListener('message', async (e) => {
               });
 
               // Translate: If no existing call log, create condition here to navigate to auto log
-              if (userCore.getAutoLogCallSetting(userSettings).value && data.body.triggerType === 'callLogSync' && !(existingCalls?.length > 0 && existingCalls[0]?.matched)) {
-                data.body.triggerType = 'createLog';
-                isAutoLog = true;
+              if (data.body.triggerType === 'callLogSync' && !(existingCalls?.length > 0 && existingCalls[0]?.matched)) {
+                if (shouldAutoLogCall(data.body.call, userSettings)) {
+                  data.body.triggerType = 'createLog';
+                  isAutoLog = true;
+                }
               }
 
               // Translate: Right after call, once presence update to Disconnect, auto log the call
               if (data.body.triggerType === 'presenceUpdate') {
                 if (data.body.call.result === 'Disconnected' || data.body.call.result === 'CallConnected') {
-                  data.body.triggerType = 'createLog';
-                  isAutoLog = true;
+                  if (shouldAutoLogCallFromPresence(data.body.call, userSettings)) {
+                    data.body.triggerType = 'createLog';
+                    isAutoLog = true;
+                  } else {
+                    responseMessage(data.requestId, { data: 'ok' });
+                    break;
+                  }
                 }
                 else {
                   responseMessage(data.requestId, { data: 'ok' });

src/service/embeddableServices.js

@@ -142,7 +142,7 @@ async function getServiceManifest() {
                     {
                         id: "logSyncFrequency",
                         type: "option",
-                        name: 'Log sync frequency',
+                        name: 'Call Log Sync Frequency',
                         helper: `Specify how often you'd like to check for any unlogged calls.`,
                         options: [
                             {

src/service/logService.js

@@ -5,6 +5,8 @@ import contactCore from '../core/contact';
 import { showNotification, dismissNotification, isObjectEmpty, getRcAccessToken } from '../lib/util';
 import { getLogConflictInfo } from '../lib/logUtil';
 
+
+
 async function retroAutoCallLog({
     manifest,
     platformName,
@@ -35,9 +37,13 @@ async function retroAutoCallLog({
         try {
             const { calls, hasMore } = await RCAdapter.getUnloggedCalls(itemsPerPage, pageNumber);
 
-            const isAutoLog = userCore.getAutoLogCallSetting(userSettings, isAdmin).value;
+            // Check if any individual auto-logging setting is enabled
+            const hasAnyAutoLogEnabled = (userSettings?.autoLogAnsweredIncoming?.value ?? false) ||
+                (userSettings?.autoLogMissedIncoming?.value ?? false) ||
+                (userSettings?.autoLogOutgoing?.value ?? false) ||
+                (userSettings?.autoLogCall?.value ?? false);
 
-            if (!isAutoLog) {
+            if (!hasAnyAutoLogEnabled) {
                 return;
             }
 
@@ -73,7 +79,7 @@ async function retroAutoCallLog({
 
                     const { hasConflict, autoSelectAdditionalSubmission } = await getLogConflictInfo({
                         platform,
-                        isAutoLog,
+                        isAutoLog: true,
                         contactInfo: callMatchedContact,
                         logType: 'callLog',
                         direction: c.direction,