Skip to content

Commit f253cd8

Browse files
committed
chore(runner): add explicit close reason when client runner shuts down (#3382)
1 parent aa4fc4c commit f253cd8

File tree

1 file changed

+16
-13
lines changed
  • engine/sdks/typescript/runner/src

1 file changed

+16
-13
lines changed

engine/sdks/typescript/runner/src/mod.ts

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ export class Runner {
386386
const pegboardWebSocket = this.#pegboardWebSocket;
387387
if (immediate) {
388388
// Stop immediately
389-
pegboardWebSocket.close(1000, "Stopping");
389+
pegboardWebSocket.close(1000, "pegboard.runner_shutdown");
390390
} else {
391391
// Wait for actors to shut down before stopping
392392
try {
@@ -431,7 +431,7 @@ export class Runner {
431431
this.log?.info({
432432
msg: "closing WebSocket",
433433
});
434-
pegboardWebSocket.close(1000, "Stopping");
434+
pegboardWebSocket.close(1000, "pegboard.runner_shutdown");
435435

436436
await closePromise;
437437

@@ -681,22 +681,25 @@ export class Runner {
681681
closeError?.group === "ws" &&
682682
closeError?.error === "eviction"
683683
) {
684-
this.log?.info({
685-
msg: "runner evicted",
686-
});
684+
this.log?.info("runner websocket evicted");
687685

688686
this.#config.onDisconnected(ev.code, ev.reason);
689687

690688
await this.shutdown(true);
691689
} else {
692-
this.log?.warn({
693-
msg: "runner disconnected",
694-
namespace: this.#config.namespace,
695-
runnerName: this.#config.runnerName,
696-
code: ev.code,
697-
reason: ev.reason.toString(),
698-
closeError,
699-
});
690+
if (
691+
closeError?.group === "pegboard" &&
692+
closeError?.error === "runner_shutdown"
693+
) {
694+
this.log?.info("runner shutdown");
695+
} else {
696+
this.log?.warn({
697+
msg: "runner disconnected",
698+
code: ev.code,
699+
reason: ev.reason.toString(),
700+
closeError,
701+
});
702+
}
700703

701704
this.#config.onDisconnected(ev.code, ev.reason);
702705
}

0 commit comments

Comments
 (0)