fixed ruff issues and initial mypy issues

Author: rjalexa

src/api/__init__.py

@@ -11,45 +11,45 @@ class Settings(BaseSettings):
     """Application settings."""
 
     # Redis Configuration
-    redis_url: str = Field(default="redis://localhost:6379/0", env="REDIS_URL")
+    redis_url: str = Field(default="redis://localhost:6379/0")
 
     # Celery Configuration
     celery_broker_url: str = Field(
-        default="redis://localhost:6379/0", env="CELERY_BROKER_URL"
+        default="redis://localhost:6379/0"
     )
     celery_result_backend: str = Field(
-        default="redis://localhost:6379/0", env="CELERY_RESULT_BACKEND"
+        default="redis://localhost:6379/0"
     )
 
     # Task Processing Configuration
-    default_retry_ratio: float = Field(default=0.3, env="DEFAULT_RETRY_RATIO")
-    max_retries: int = Field(default=3, env="MAX_RETRIES")
-    max_task_age: int = Field(default=3600, env="MAX_TASK_AGE")  # 1 hour
+    default_retry_ratio: float = Field(default=0.3)
+    max_retries: int = Field(default=3)
+    max_task_age: int = Field(default=3600)  # 1 hour
 
     # Queue Pressure Thresholds
-    retry_queue_warning: int = Field(default=1000, env="RETRY_QUEUE_WARNING")
-    retry_queue_critical: int = Field(default=5000, env="RETRY_QUEUE_CRITICAL")
+    retry_queue_warning: int = Field(default=1000)
+    retry_queue_critical: int = Field(default=5000)
 
     # Circuit Breaker Configuration
     circuit_failure_threshold: float = Field(
-        default=0.5, env="CIRCUIT_FAILURE_THRESHOLD"
+        default=0.5
     )
-    circuit_volume_threshold: int = Field(default=10, env="CIRCUIT_VOLUME_THRESHOLD")
-    circuit_timeout: int = Field(default=60, env="CIRCUIT_TIMEOUT")
+    circuit_volume_threshold: int = Field(default=10)
+    circuit_timeout: int = Field(default=60)
 
     # OpenRouter Configuration
-    openrouter_api_key: Optional[str] = Field(default=None, env="OPENROUTER_API_KEY")
+    openrouter_api_key: Optional[str] = Field(default=None)
     openrouter_base_url: str = Field(
-        default="https://openrouter.ai/api/v1", env="OPENROUTER_BASE_URL"
+        default="https://openrouter.ai/api/v1"
     )
     openrouter_model: str = Field(
-        default="meta-llama/llama-3.2-90b-text-preview", env="OPENROUTER_MODEL"
+        default="meta-llama/llama-3.2-90b-text-preview"
     )
-    openrouter_timeout: int = Field(default=30, env="OPENROUTER_TIMEOUT")
+    openrouter_timeout: int = Field(default=30)
 
     # Development Configuration
-    debug: bool = Field(default=False, env="DEBUG")
-    log_level: str = Field(default="INFO", env="LOG_LEVEL")
+    debug: bool = Field(default=False)
+    log_level: str = Field(default="INFO")
 
     # API Configuration
     api_title: str = "AsyncTaskFlow API"
@@ -58,9 +58,11 @@ class Settings(BaseSettings):
     docs_url: str = "/docs"
     redoc_url: str = "/redoc"
 
-    class Config:
-        env_file = ".env"
-        case_sensitive = False
+    model_config = {
+        "env_file": ".env",
+        "case_sensitive": False,
+        "env_prefix": "",
+    }
 
 
 # Global settings instance

src/api/config.py

@@ -3,12 +3,22 @@
 
 import os
 from contextlib import asynccontextmanager
+from typing import AsyncGenerator
 
 from fastapi import FastAPI
 from fastapi.middleware.cors import CORSMiddleware
 
 from config import settings
-from routers import health, tasks, queues, summarize, workers, pdfxtract, redis, openrouter
+from routers import (
+    health,
+    tasks,
+    queues,
+    summarize,
+    workers,
+    pdfxtract,
+    redis,
+    openrouter,
+)
 from services import RedisService, TaskService, QueueService, HealthService
 import services  # Import the module to modify globals
 
@@ -33,7 +43,7 @@
 )
 
 
-async def initialize_services() -> tuple:
+async def initialize_services() -> tuple[RedisService, TaskService, QueueService, HealthService]:
     """Initialize all services and return them."""
     print(f"Initializing services in process {os.getpid()}")
 
@@ -44,7 +54,7 @@ async def initialize_services() -> tuple:
     # Test Redis connection
     redis_ok = await redis_service.ping()
     print(f"Redis connection: {'OK' if redis_ok else 'FAILED'}")
-    
+
     if redis_ok:
         # Log connection pool stats
         pool_stats = await redis_service.get_pool_stats()
@@ -61,7 +71,7 @@ async def initialize_services() -> tuple:
 
 
 @asynccontextmanager
-async def lifespan(app: FastAPI):
+async def lifespan(app: FastAPI) -> AsyncGenerator[None, None]:
     """Application lifespan events."""
     # Startup
     print("🚀 Starting AsyncTaskFlow API...")
@@ -141,7 +151,7 @@ async def lifespan(app: FastAPI):
 
 
 @app.get("/")
-async def root():
+async def root() -> dict[str, str]:
     """Root endpoint."""
     return {
         "message": "AsyncTaskFlow API",