♻️ Reuse gitmob.reload command

When data changes happen the UI needs to be updated and this can be achieved using the reload command vs duplicate calls to the reloadData functions on coAuthorProvider.

Author: rkotze

src/reload-on-save.js

@@ -1,13 +1,12 @@
 const vscode = require("vscode");
 const { CONSTANTS } = require("./constants");
 
-function reloadOnSave({ coAuthorProvider }) {
+function reloadOnSave() {
   const { onDidSaveTextDocument } = vscode.workspace;
 
   onDidSaveTextDocument(async function (textDocument) {
     if (textDocument.fileName.includes(CONSTANTS.GIT_COAUTHORS_FILE)) {
-      await coAuthorProvider.coAuthorGroups.reloadData();
-      coAuthorProvider.reloadData();
+      await vscode.commands.executeCommand("gitmob.reload");
     }
   });
 }

src/reload-on-save.spec.js

@@ -2,12 +2,6 @@ const { reloadOnSave } = require("./reload-on-save");
 const { CONSTANTS } = require("./constants");
 const vscode = require("../__mocks__/vscode");
 
-const coAuthorProviderStub = {
-  reloadData: jest.fn(),
-  coAuthorGroups: {
-    reloadData: jest.fn(),
-  },
-};
 const coAuthorTextDocStub = {
   fileName: `file/Path/to/${CONSTANTS.GIT_COAUTHORS_FILE}`,
 };
@@ -23,29 +17,27 @@ beforeEach(() => {
 });
 
 afterEach(() => {
-  coAuthorProviderStub.reloadData.mockReset();
-  coAuthorProviderStub.coAuthorGroups.reloadData.mockReset();
   saveTrigger = null;
 });
 
 test("Reload co-author list when git-coauthors file saved", async () => {
-  reloadOnSave({ coAuthorProvider: coAuthorProviderStub });
+  reloadOnSave();
   expect(vscode.workspace.onDidSaveTextDocument).toHaveBeenCalledWith(
     expect.any(Function)
   );
   await saveTrigger(coAuthorTextDocStub);
-  expect(coAuthorProviderStub.reloadData).toHaveBeenCalledTimes(1);
-  expect(coAuthorProviderStub.coAuthorGroups.reloadData).toHaveBeenCalledTimes(
-    1
-  );
+  expect(vscode.commands.executeCommand).toHaveBeenCalledTimes(1);
+  expect(vscode.commands.executeCommand).toHaveBeenCalledWith("gitmob.reload");
 });
 
 test("Do NOT reload co-author list when other files are saved", async () => {
-  reloadOnSave({ coAuthorProvider: coAuthorProviderStub });
+  reloadOnSave();
   expect(vscode.workspace.onDidSaveTextDocument).toHaveBeenCalledWith(
     expect.any(Function)
   );
   await saveTrigger(otherTextDocStub);
-  expect(coAuthorProviderStub.reloadData).not.toHaveBeenCalled();
-  expect(coAuthorProviderStub.coAuthorGroups.reloadData).not.toHaveBeenCalled();
+  expect(vscode.commands.executeCommand).not.toHaveBeenCalled();
+  expect(vscode.commands.executeCommand).not.toHaveBeenCalledWith(
+    "gitmob.reload"
+  );
 });

src/setup-git-mob.js

@@ -69,16 +69,15 @@ async function bootGitMob(context, gitExt) {
 
     disposables.forEach((dispose) => context.subscriptions.push(dispose));
 
-    reloadOnSave({ coAuthorProvider });
+    reloadOnSave();
     soloAfterCommit(coAuthorProvider);
 
     gitExt.onDidChangeUiState(async function () {
       if (gitExt.repositories.length === 1) return;
       if (this.ui.selected) {
         gitExt.selectedRepositoryPath = this.rootUri.path;
         updateConfig("processCwd", gitExt.rootPath);
-        await coAuthorProvider.coAuthorGroups.reloadData();
-        coAuthorProvider.reloadData();
+        await vscode.commands.executeCommand("gitmob.reload");
       }
     });
 

test/extension.test.js

@@ -143,7 +143,6 @@ describe("GitMob core tests", function () {
     );
 
     await vscode.commands.executeCommand("gitmob.reload");
-
     await vscode.commands.executeCommand("gitmob.addCoAuthor", coAuthor);
     await wait(200);