Skip to content

run_partials isn’t compatible with all execution #5412

@gmac

Description

@gmac

I came across run_partials and it looks super interesting, and useful for some of our needs. I’m curious what it was specifically added for given that it’s not used in the library itself…?

Trying it out, it doesn’t seem to work with a schema of any real sophistication. It breaks on common tracing patterns that reference GraphQL::Query through context, but get a Partial that seems to only loosely duck-type with Query instead (in our case, we use Sorbet a lot so the proper type identity is actually important). The capability would be terrific, but I think Partial needs to actually extend from Query and fully implement it if it’s going to replace it sometimes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions