Skip to content

Commit 66aa98e

Browse files
authored
Add input continue warning for wrong ultralytics version in model deploy (#185)
* Add input continue warning for wrong ultralytics version in model deploy * Put import sys in correct order in versions.py * Bump package version to 1.1.6
1 parent 78c15e9 commit 66aa98e

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

roboflow/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from roboflow.core.workspace import Workspace
1313
from roboflow.util.general import write_line
1414

15-
__version__ = "1.1.5"
15+
__version__ = "1.1.6"
1616

1717

1818
def check_key(api_key, model, notebook, num_retries=0):

roboflow/core/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,7 @@ def deploy(self, model_type: str, model_path: str) -> None:
490490
)
491491

492492
print_warn_for_wrong_dependencies_versions(
493-
[("ultralytics", "==", "8.0.134")]
493+
[("ultralytics", "==", "8.0.134")], ask_to_continue=True
494494
)
495495

496496
elif "yolov5" in model_type or "yolov7" in model_type:

roboflow/util/versions.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import sys
12
from importlib import import_module
23
from typing import List, Tuple
34

@@ -42,13 +43,19 @@ def get_wrong_dependencies_versions(
4243

4344

4445
def print_warn_for_wrong_dependencies_versions(
45-
dependencies_versions: List[Tuple[str, str, str]]
46+
dependencies_versions: List[Tuple[str, str, str]], ask_to_continue: bool = False
4647
):
4748
wrong_dependencies_versions = get_wrong_dependencies_versions(dependencies_versions)
4849
for dependency, order, version, module_version in wrong_dependencies_versions:
4950
print(
5051
f"Dependency {dependency}{order}{version} is required but found version={module_version}, to fix: `pip install {dependency}{order}{version}`"
5152
)
53+
if ask_to_continue:
54+
answer = input(
55+
f"Would you like to continue with the wrong version of {dependency}? y/n: "
56+
)
57+
if answer.lower() != "y":
58+
sys.exit(1)
5259

5360

5461
def warn_for_wrong_dependencies_versions(

0 commit comments

Comments
 (0)