Skip to content

Commit 9e5ec7a

Browse files
committed
fix poetry is not found on windows
1 parent 517189b commit 9e5ec7a

File tree

1 file changed

+7
-20
lines changed

1 file changed

+7
-20
lines changed

.github/workflows/build-template.yaml

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,10 @@ jobs:
7373
run: |
7474
python -m pip install --upgrade pip setuptools pyinstaller
7575
curl -sSL https://install.python-poetry.org | python3 - --version ${{ env.POETRY_VERSION }}
76-
echo "C:\Users\runneradmin\AppData\Roaming\Python\Scripts" | Out-File -FilePath "$env:GITHUB_PATH" -Encoding utf8 -Append
77-
78-
poetry config virtualenvs.create false
79-
poetry install --no-root
76+
C:\Users\runneradmin\AppData\Roaming\Python\Scripts\poetry config virtualenvs.create false
77+
C:\Users\runneradmin\AppData\Roaming\Python\Scripts\poetry install --no-root
78+
# Updated GITHUB_PATH works on next steps, not current step somehow
79+
echo "C:\Users\runneradmin\AppData\Roaming\Python\Scripts" >> $env:GITHUB_PATH
8080
8181
# Linux-specific system dependencies
8282
- name: Install system dependencies (Linux)
@@ -117,11 +117,12 @@ jobs:
117117
run: |
118118
$filePath = 'holmes/__init__.py'
119119
(Get-Content $filePath) -replace '__version__ = .+', '__version__ = "${{ github.ref_name }}"' | Set-Content $filePath
120-
shell: pwsh
121120
122121
# Build step with PyInstaller
123122
- name: Build binary with PyInstaller
124123
shell: bash
124+
# regarding the tiktoken part of the command, see https://github.com/openai/tiktoken/issues/80
125+
# regarding the litellm part of the command, see https://github.com/pyinstaller/pyinstaller/issues/8620#issuecomment-2186540504
125126
run: |
126127
# Customize this PyInstaller command based on your project structure
127128
pyinstaller holmes_cli.py \
@@ -141,20 +142,9 @@ jobs:
141142
--collect-data litellm
142143
ls dist/
143144
144-
# Optional: Run tests
145-
- name: Run tests(Unix)
146-
if: ${{ !inputs.is-release }} && matrix.os != 'windows-latest'
147-
shell: bash
148-
env:
149-
# Add your test environment variables here
150-
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
151-
run: |
152-
poetry run pytest -m "not llm"
153-
154145
# Optional: Run tests
155146
- name: Run tests(Windows)
156-
if: ${{ !inputs.is-release }} && matrix.os == 'windows-latest'
157-
shell: pwsh
147+
if: ${{ !inputs.is-release }}
158148
env:
159149
# Add your test environment variables here
160150
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
@@ -164,7 +154,6 @@ jobs:
164154
# Test the built binary
165155
- name: Test binary (Unix)
166156
if: matrix.os != 'windows-latest'
167-
shell: bash
168157
run: |
169158
dist/holmes/holmes version
170159
if [ $? -ne 0 ]; then
@@ -175,7 +164,6 @@ jobs:
175164
176165
- name: Test binary (Windows)
177166
if: matrix.os == 'windows-latest'
178-
shell: pwsh
179167
run: |
180168
dist/holmes/holmes.exe version
181169
if ($LASTEXITCODE -ne 0) {
@@ -200,7 +188,6 @@ jobs:
200188
Compress-Archive -Path holmes -DestinationPath holmes-${{ matrix.os }}-${{ github.run_number }}.zip -Force
201189
Move-Item -Path holmes-${{ matrix.os }}-${{ github.run_number }}.zip -Destination ..\
202190
Set-Location -Path ..
203-
shell: pwsh
204191
205192
# Upload artifacts
206193
- name: Upload build artifacts

0 commit comments

Comments
 (0)