post spans from tracing exporter (#1335)

Author: waltjones

src/browser/core.js

@@ -36,7 +36,7 @@ class Rollbar {
     const transport = new Transport(truncation);
     const api = new API(this.options, transport, urllib, truncation);
     if (Tracing) {
-      this.tracing = new Tracing(_gWindow(), this.options);
+      this.tracing = new Tracing(_gWindow(), api, this.options);
       this.tracing.initSession();
     }
     if (Telemeter) {

src/tracing/exporter.js

@@ -5,6 +5,11 @@ import hrtime from './hrtime.js';
  * and transforming them into the OTLP-compatible format.
  */
 export class SpanExporter {
+  constructor(api, options = {}) {
+    this.api = api;
+    this.options = options;
+  }
+
   /**
    * Export spans to the span export queue
    *
@@ -66,6 +71,17 @@ export class SpanExporter {
     };
   }
 
+  /**
+   * Sends the given payload to the Rollbar API.
+   *
+   * @param {String} payload - Serialized OTLP format payload
+   * @param {Object} headers - Optional request headers
+   * @returns {Promise} Promise that resolves when the request completes
+   */
+  post(payload, headers = {}) {
+    return this.api.postSpans(payload, headers);
+  }
+
   /**
    * Transforms a ReadableSpan into the OTLP Span format
    *

src/tracing/tracing.js

@@ -8,7 +8,8 @@ import id from './id.js';
 const SPAN_KEY = createContextKey('Rollbar Context Key SPAN');
 
 export default class Tracing {
-  constructor(gWindow, options) {
+  constructor(gWindow, api, options) {
+    this.api = api;
     this.options = options;
     this.window = gWindow;
 
@@ -59,7 +60,7 @@ export default class Tracing {
 
   createTracer() {
     this.contextManager = new ContextManager();
-    this.exporter = new SpanExporter();
+    this.exporter = new SpanExporter(this.api, this.options);
     this.spanProcessor = new SpanProcessor(this.exporter, this.options.tracing);
     this.tracer = new Tracer(this, this.spanProcessor);
   }

test/browser.telemetry.test.js

@@ -76,7 +76,7 @@ describe('instrumentDom', function () {
     await loadHtml('test/fixtures/html/dom-events.html');
     scrubFields = ['foo', 'bar'];
     rollbar = new Rollbar({})
-    tracing = new Tracing(window, {})
+    tracing = new Tracing(window, null, {})
     tracing.initSession();
     telemeter = new Telemeter({}, tracing);
     instrumenter = new Instrumenter(

test/replay/integration/e2e.test.js

@@ -66,7 +66,7 @@ describe('Session Replay E2E', function () {
     };
     const logger = { error: sinon.spy(), log: sinon.spy() };
 
-    tracing = new Tracing(window, options);
+    tracing = new Tracing(window, null, options);
     tracing.initSession();
     api = new Api(
       { accessToken: 'test-token-12345' },

test/replay/integration/replayManager.test.js

@@ -47,7 +47,7 @@ describe('ReplayManager API Integration', function () {
       truncate: sinon.stub().returns({ error: null, value: '{}' }),
     };
 
-    tracing = new Tracing(window, options);
+    tracing = new Tracing(window, null, options);
     tracing.initSession();
 
     const mockPayload = [{ id: 'span1', name: 'recording-span' }];

test/replay/integration/sessionRecording.test.js

@@ -64,7 +64,7 @@ describe('Session Replay Integration', function () {
   let recorder;
 
   beforeEach(function () {
-    tracing = new Tracing(window, options);
+    tracing = new Tracing(window, null, options);
     tracing.initSession();
   });
 
@@ -207,7 +207,7 @@ describe('Session Replay Transport Integration', function () {
       truncate: sinon.stub().returns({ error: null, value: '{}' }),
     };
 
-    tracing = new Tracing(window, options);
+    tracing = new Tracing(window, null, options);
     tracing.initSession();
 
     api = new Api(

test/telemetry.test.js

@@ -49,6 +49,7 @@ describe('capture events', function () {
   beforeEach(function () {
     const tracing = new Tracing(
       window,
+      null,
       {
         resource: {
           'service.name': 'Test',

test/tracing/tracing.test.js

@@ -1,6 +1,7 @@
 import { expect } from 'chai';
 import sinon from 'sinon';
 
+import Api from '../../src/api.js';
 import {
   ContextManager,
   createContextKey,
@@ -28,7 +29,7 @@ const tracingOptions = function (options = {}) {
 describe('Tracing()', function () {
   it('should initialize', function (done) {
     const options = tracingOptions();
-    const t = new Tracing(window, options);
+    const t = new Tracing(window, null, options);
     t.initSession();
 
     expect(t).to.have.property('initSession').and.to.be.a('function');
@@ -53,7 +54,7 @@ describe('Tracing()', function () {
 
   it('should configure', function () {
     const options = tracingOptions();
-    const t = new Tracing(window, options);
+    const t = new Tracing(window, null, options);
     t.initSession();
 
     expect(t.options.resource).to.deep.equal(options.resource);
@@ -74,7 +75,7 @@ describe('Tracing()', function () {
 
   it('should create and export spans', function (done) {
     const options = tracingOptions();
-    const t = new Tracing(window, options);
+    const t = new Tracing(window, null, options);
     t.initSession();
 
     expect(t.sessionId).to.match(/^[a-f0-9]{32}$/);
@@ -120,7 +121,7 @@ describe('Tracing()', function () {
 
   it('should create spans with span option overrides', function () {
     const options = tracingOptions();
-    const t = new Tracing(window, options);
+    const t = new Tracing(window, null, options);
     t.initSession();
 
     expect(t.sessionId).to.match(/^[a-f0-9]{32}$/);
@@ -143,7 +144,7 @@ describe('Tracing()', function () {
 
   it('should get and set session attributes', function () {
     const options = tracingOptions();
-    const t = new Tracing(window, options);
+    const t = new Tracing(window, null, options);
     t.initSession();
 
     t.session.setAttributes({codeVersion: 'abc123'});
@@ -162,7 +163,7 @@ describe('Tracing()', function () {
   it('should not init session when sessionStorage is not detected', function () {
     const stub = sinon.stub(window, 'sessionStorage').value(undefined);
     const options = tracingOptions();
-    const t = new Tracing(window, options);
+    const t = new Tracing(window, null, options);
 
     // calling initSession should be a no-op
     t.initSession();
@@ -173,12 +174,70 @@ describe('Tracing()', function () {
 
   it('should generate ids', function (done) {
     const options = tracingOptions();
-    const t = new Tracing(window, options);
+    const t = new Tracing(window, null, options);
 
     const replayId = t.idGen(8);
 
     expect(replayId).to.match(/^[a-f0-9]{16}$/);
 
     done();
   });
+
+  describe('post', function () {
+    let api;
+    let transport;
+    let tracing;
+
+    beforeEach(function () {
+      transport = {
+        post: sinon
+          .stub()
+          .callsFake(({ accessToken, options, payload, callback }) => {
+            setTimeout(() => {
+              callback(
+                null,
+                { err: 0, result: { id: '12345' } },
+              );
+            }, 1);
+          }),
+        postJsonPayload: sinon.stub(),
+      };
+      const urlMock = { parse: sinon.stub().returns({}) };
+      const truncationMock = {
+        truncate: sinon.stub().returns({ error: null, value: '{}' }),
+      };
+
+      api = new Api(
+        { accessToken: 'test-token-12345' },
+        transport,
+        urlMock,
+        truncationMock,
+      );
+      tracing = new Tracing(window, api, {});
+      tracing.initSession();
+    });
+
+    afterEach(function () {
+      sinon.restore();
+    });
+
+    it('should post a trace payload', function (done) {
+      const span = tracing.startSpan('test.span');
+      span.end();
+      tracing.exporter.post(
+        tracing.exporter.toPayload(),
+        { 'X-Rollbar-Session-Id': tracing.sessionId }
+      );
+
+      setTimeout(() => {
+        expect(transport.post.callCount).to.equal(1);
+        const call = transport.post.getCall(0);
+        const { payload, headers } = call.args[0];
+        expect(payload).to.have.property('resourceSpans');
+        expect(headers).to.have.property('X-Rollbar-Session-Id', tracing.sessionId);
+
+        done();
+      }, 10);
+    });
+  });
 });