From 0d73db602c438bdf3ddb44955e00a7517bcad27c Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Fri, 1 Aug 2025 08:14:54 +0200 Subject: [PATCH 1/5] [nfc][core] fix wrong docu in default error handler --- core/base/src/TErrorDefaultHandler.cxx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/base/src/TErrorDefaultHandler.cxx b/core/base/src/TErrorDefaultHandler.cxx index dc5cfbea4d54d..8fa6c9e6419f8 100644 --- a/core/base/src/TErrorDefaultHandler.cxx +++ b/core/base/src/TErrorDefaultHandler.cxx @@ -95,10 +95,10 @@ static void DebugPrint(const char *fmt, ...) /// The default error handler function. It prints the message on stderr and -/// if abort is set it aborts the application. Replaces the minimal error handler -/// of TError.h as part of the gROOT construction. TError's minimal handler is put +/// if abort is set it aborts the application. Replaces the minimal error handler +/// of TError.h as part of the gROOT construction. TError's minimal handler is put /// back in place during the gROOT destruction. -/// @note `abort()` is only called if `abort_bool` is `true` and `level < gErrorIgnoreLevel` +/// @note `abort()` is only called if `abort_bool` is `true` and `level >= gErrorIgnoreLevel` void DefaultErrorHandler(Int_t level, Bool_t abort_bool, const char *location, const char *msg) { if (gErrorIgnoreLevel == kUnset) { From eceeb464f639eb1ad73784d7feefb32e5e1f162f Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Fri, 1 Aug 2025 08:23:18 +0200 Subject: [PATCH 2/5] [nfc][core] add documentation for global TError variables --- core/foundation/inc/TError.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/foundation/inc/TError.h b/core/foundation/inc/TError.h index f1f249207f404..a78d5a31f4831 100644 --- a/core/foundation/inc/TError.h +++ b/core/foundation/inc/TError.h @@ -137,8 +137,8 @@ R__EXTERN const char *kCheckMsg; ::Warning("", kCheckMsg, _QUOTE_(e), __LINE__, __FILE__); \ } while (false) -R__EXTERN Int_t gErrorIgnoreLevel; -R__EXTERN Int_t gErrorAbortLevel; -R__EXTERN Bool_t gPrintViaErrorHandler; +R__EXTERN Int_t gErrorIgnoreLevel; ///< errors with level below this value will be ignored. Default is `kUnset`. +R__EXTERN Int_t gErrorAbortLevel; ///< non-ignored errors with level equal or above this value will call abort(). Default is `kSysError+1`. +R__EXTERN Bool_t gPrintViaErrorHandler;///< If true, ROOT's `Printf` will print via the currently active ROOT error handler; if false, it will use the standard `printf`. #endif From b0587b60746be68b5ea85099fa35bb0e6fac859e Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Fri, 1 Aug 2025 08:24:42 +0200 Subject: [PATCH 3/5] [nfc] mention default --- core/foundation/inc/TError.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/foundation/inc/TError.h b/core/foundation/inc/TError.h index a78d5a31f4831..db139182234c1 100644 --- a/core/foundation/inc/TError.h +++ b/core/foundation/inc/TError.h @@ -139,6 +139,6 @@ R__EXTERN const char *kCheckMsg; R__EXTERN Int_t gErrorIgnoreLevel; ///< errors with level below this value will be ignored. Default is `kUnset`. R__EXTERN Int_t gErrorAbortLevel; ///< non-ignored errors with level equal or above this value will call abort(). Default is `kSysError+1`. -R__EXTERN Bool_t gPrintViaErrorHandler;///< If true, ROOT's `Printf` will print via the currently active ROOT error handler; if false, it will use the standard `printf`. +R__EXTERN Bool_t gPrintViaErrorHandler;///< If true, ROOT's `Printf` will print via the currently active ROOT error handler; if false (default), it will use the standard `printf`. #endif From 8e25e9e0b209262a8f8907e2bb26745de157d58a Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Sat, 2 Aug 2025 12:42:17 +0200 Subject: [PATCH 4/5] [nfc][graf2d] remove ambiguity in docu --- graf2d/gpad/src/TPad.cxx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/graf2d/gpad/src/TPad.cxx b/graf2d/gpad/src/TPad.cxx index 43903462ea568..ac2f09a2fc32c 100644 --- a/graf2d/gpad/src/TPad.cxx +++ b/graf2d/gpad/src/TPad.cxx @@ -5063,7 +5063,8 @@ static Bool_t ContainsTImage(TList *li) /// generated in some loop one needs to detect the special cases of first /// and last page and then munge the argument to Print() accordingly. /// -/// The "[" and "]" can be used instead of "(" and ")". +/// The "[" and "]" can be used instead of "(" and ")" to open / close without +/// actual printing. /// /// Example: /// ~~~ {.cpp} From ee5d4a2f84b92f31ca7ac9323fe47644befcbb2d Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Sat, 2 Aug 2025 12:44:13 +0200 Subject: [PATCH 5/5] [nfc][math] fix codeblock docu --- math/mathcore/src/TKDTree.cxx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/math/mathcore/src/TKDTree.cxx b/math/mathcore/src/TKDTree.cxx index 3474a04cf93d2..143ea34e5d088 100644 --- a/math/mathcore/src/TKDTree.cxx +++ b/math/mathcore/src/TKDTree.cxx @@ -115,9 +115,13 @@ in the 2 subtrees as close as possible. The following section gives more details kdtree->SetData(2, datatree->GetV3()); kdtree->Build(); } +\endcode + NOTE, that this implementation of kd-tree doesn't support adding new points after the tree has been built Of course, it's not necessary to use TTree::Draw(). What is important, is to have data columnwise. An example with regular arrays: + +\code{.cpp} { Int_t npoints = 100000; Int_t ndim = 3;