-
Notifications
You must be signed in to change notification settings - Fork 266
[example_5] Update demo to illustrate the usage of wrench transformer #972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[example_5] Update demo to illustrate the usage of wrench transformer #972
Conversation
example_5/bringup/launch/rrbot_system_with_external_sensor.launch.py
Outdated
Show resolved
Hide resolved
example_5/bringup/launch/rrbot_system_with_external_sensor.launch.py
Outdated
Show resolved
Hide resolved
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The failing tests may be a consequence of
2025-11-23T02:20:27.7426040Z 3: [ERROR] [launch]: Caught exception in launch (see debug for traceback): package 'force_torque_sensor_broadcaster' found at '/home/runner/work/ros2_control_demos/ros2_control_demos/.work/upstream_ws/install/force_torque_sensor_broadcaster', but libexec directory '/home/runner/work/ros2_control_demos/ros2_control_demos/.work/upstream_ws/install/force_torque_sensor_broadcaster/lib/force_torque_sensor_broadcaster' does not exist
2025-11-23T02:20:27.7428853Z 3: Processes under test stopped before tests completed
Let's wait for the upstream PR to be merged.
|
|
||
| def test_wrench_transformer_node_start(self, proc_output): | ||
| """Test that the wrench transformer node starts when use_wrench_transformer is true.""" | ||
| check_node_running(self.node, "fts_wrench_transformer") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add a test if the expected topic is published? Just to ensure that the documentation is in accordance with the actual behavior of the node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not using WaitForTopics?
https://docs.ros.org/en/rolling/p/launch_testing_ros/launch_testing_ros.wait_for_topics.html
It hides just the subscription inside
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is new to me, thanks for pointing it out. It's indeed handy, updated the test.
@christophfroehlich, this test failure still persists in the latest runs. I suspect it was due to The version from source main package.xml is at 6.0.0. Let me know if further debugging is needed. Thanks a bunch! |
This is expected behavior. binary build install the released packages, the rolling semi-binary build is green (compiling ros2_controller from source), kilted semi-binary is failing because we haven't merged the backports yet. |
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx :)
Companion PR for ros-controls/ros2_controllers#2021
This augments example_5 to demonstrate the wrench transformer utility node for the force_torque_sensor_broadcaster.
use_wrench_transformeris introduced to control whether to launch the wrench transformer node, by default, it is false.