fic call of AddHistoryRecord()

[skip ci]

Author: rosasurfer

mql40/experts/ZigZag EA.mq4

@@ -1188,7 +1188,7 @@ bool SynchronizeStatus() {
             double   netProfitP   = grossProfitP + MathDiv(swapM + commissionM, PointValue(lots));
 
             logWarn("SynchronizeStatus(4)  "+ instance.name +" orphaned closed position found: #"+ ticket +", adding to instance...");
-            if (IsEmpty(AddHistoryRecord(ticket, 0, 0, lots, 1, openType, openTime, openPrice, openPrice, stopLoss, takeProfit, closeTime, closePrice, closePrice, slippageP, swapM, commissionM, grossProfitM, netProfitM, netProfitP, grossProfitP, grossProfitP, grossProfitP, grossProfitP, grossProfitP))) return(false);
+            if (IsEmpty(AddHistoryRecord(ticket, 0, 0, openType, lots, 1, openTime, openPrice, openPrice, stopLoss, takeProfit, closeTime, closePrice, closePrice, slippageP, swapM, commissionM, grossProfitM, netProfitM, netProfitP, grossProfitP, grossProfitP, grossProfitP, grossProfitP, grossProfitP))) return(false);
 
             // update closed PL numbers
             stats[NET_MONEY][S_CLOSED_PROFIT] += netProfitM;

mql40/experts/tools/HtmlReport2Chart.mq4

@@ -524,7 +524,7 @@ bool UpdateHistoryRecord(int ticket, double stopLoss, double takeProfit, datetim
    int size = ArrayRange(history, 0);
 
    // find the ticket to update
-   for (int i=size-1; i >= 0; i--) {                  // iterate from the end (in most use cases faster)
+   for (int i=size-1; i >= 0; i--) {                  // iterate from the end (in most cases faster)
       if (ticket == history[i][H_TICKET]) break;
    }
    if (i < 0) return(!catch("UpdateHistoryRecord(1)  ticket #"+ ticket +" not found", ERR_INVALID_PARAMETER));

mql40/include/rsf/experts/trade/AddHistoryRecord.mqh

@@ -36,7 +36,7 @@ int AddHistoryRecord(int ticket, int fromTicket, int toTicket, int type, double
    if (isPartial) {
       // resolve the partialClose[] index to insert at
       int size = ArrayRange(partialClose, 0);
-      for (int i=size-1; i >= 0; i--) {                        // iterate from the end (in most use cases faster)
+      for (int i=size-1; i >= 0; i--) {                        // iterate from the end (in most cases faster)
          if (ticket == partialClose[i][H_TICKET]) return(_EMPTY(catch("AddHistoryRecord(1)  "+ instance.name +" cannot add record, ticket #"+ ticket +" already exists (partialClose["+ i +"])", ERR_INVALID_PARAMETER)));
 
          if (openTime > partialClose[i][H_OPENTIME]) {

templates4/17 ZigZag(50,30) + Donchian.tpl

@@ -179,8 +179,8 @@ window_num=1
 Donchian.Periods=30
 </inputs>
 </expert>
-levels_color=15453831
-levels_style=1
+levels_color=16316664
+levels_style=2
 level_0=200
 
 period_flags=0