Skip to content

Commit e9d7bcf

Browse files
rosstarossta
committed
Drop webpacker from development dependencies
Webpacker has been abandoned in the past few years. I might consider leaving the Webpacker logic in the gem until a major version release, but trying to upgrade development dependencies to get Webpacker to work in CI isn’t worth my time.
1 parent 701af47 commit e9d7bcf

File tree

11 files changed

+9
-7636
lines changed

11 files changed

+9
-7636
lines changed

‎gemfiles/rails_6.0.gemfile‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
source 'https://rubygems.org'
22

33
gem 'rails', '~> 6.0.0'
4-
gem 'webpacker', '>= 4.1'
54

65
group :development, :test do
76
gem 'guard', require: false

‎gemfiles/rails_6.0.gemfile.lock‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,6 @@ GEM
157157
pry (>= 0.13, < 0.15)
158158
racc (1.8.0)
159159
rack (2.2.9)
160-
rack-proxy (0.7.7)
161-
rack
162160
rack-test (2.1.0)
163161
rack (>= 1.3)
164162
rails (6.0.6.1)
@@ -214,7 +212,6 @@ GEM
214212
rubocop (>= 1.48.1, < 2.0)
215213
rubocop-ast (>= 1.31.1, < 2.0)
216214
ruby-progressbar (1.13.0)
217-
semantic_range (3.0.0)
218215
shellany (0.0.1)
219216
simplecov (0.22.0)
220217
docile (~> 1.1)
@@ -249,11 +246,6 @@ GEM
249246
tzinfo (1.2.11)
250247
thread_safe (~> 0.1)
251248
unicode-display_width (2.5.0)
252-
webpacker (5.4.4)
253-
activesupport (>= 5.2)
254-
rack-proxy (>= 0.6.1)
255-
railties (>= 5.2)
256-
semantic_range (>= 2.3.0)
257249
websocket-driver (0.7.6)
258250
websocket-extensions (>= 0.1.0)
259251
websocket-extensions (0.1.5)
@@ -289,7 +281,6 @@ DEPENDENCIES
289281
sprockets (~> 3.0)
290282
sprockets-rails
291283
standard
292-
webpacker (>= 4.1)
293284

294285
BUNDLED WITH
295286
2.5.16

‎gemfiles/rails_6.1.gemfile‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
source 'https://rubygems.org'
22

33
gem 'rails', '~> 6.1.0'
4-
gem 'webpacker', '>= 4.1'
54

65
group :development, :test do
76
gem 'guard', require: false

‎gemfiles/rails_6.1.gemfile.lock‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,6 @@ GEM
161161
pry (>= 0.13, < 0.15)
162162
racc (1.8.0)
163163
rack (2.2.9)
164-
rack-proxy (0.7.7)
165-
rack
166164
rack-test (2.1.0)
167165
rack (>= 1.3)
168166
rails (6.1.7.8)
@@ -218,7 +216,6 @@ GEM
218216
rubocop (>= 1.48.1, < 2.0)
219217
rubocop-ast (>= 1.31.1, < 2.0)
220218
ruby-progressbar (1.13.0)
221-
semantic_range (3.0.0)
222219
shellany (0.0.1)
223220
simplecov (0.22.0)
224221
docile (~> 1.1)
@@ -252,11 +249,6 @@ GEM
252249
tzinfo (2.0.6)
253250
concurrent-ruby (~> 1.0)
254251
unicode-display_width (2.5.0)
255-
webpacker (5.4.4)
256-
activesupport (>= 5.2)
257-
rack-proxy (>= 0.6.1)
258-
railties (>= 5.2)
259-
semantic_range (>= 2.3.0)
260252
websocket-driver (0.7.6)
261253
websocket-extensions (>= 0.1.0)
262254
websocket-extensions (0.1.5)
@@ -292,7 +284,6 @@ DEPENDENCIES
292284
sprockets (~> 3.0)
293285
sprockets-rails
294286
standard
295-
webpacker (>= 4.1)
296287

297288
BUNDLED WITH
298289
2.5.16

‎gemfiles/rails_7.0.gemfile‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
source 'https://rubygems.org'
22

33
gem 'rails', '~> 7.0.0'
4-
gem 'webpacker', '>= 4.1'
54

65
group :development, :test do
76
gem 'guard', require: false

‎gemfiles/rails_7.0.gemfile.lock‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,6 @@ GEM
167167
pry (>= 0.13, < 0.15)
168168
racc (1.8.0)
169169
rack (2.2.9)
170-
rack-proxy (0.7.7)
171-
rack
172170
rack-test (2.1.0)
173171
rack (>= 1.3)
174172
rails (7.0.8.4)
@@ -224,7 +222,6 @@ GEM
224222
rubocop (>= 1.48.1, < 2.0)
225223
rubocop-ast (>= 1.31.1, < 2.0)
226224
ruby-progressbar (1.13.0)
227-
semantic_range (3.0.0)
228225
shellany (0.0.1)
229226
simplecov (0.22.0)
230227
docile (~> 1.1)
@@ -258,11 +255,6 @@ GEM
258255
tzinfo (2.0.6)
259256
concurrent-ruby (~> 1.0)
260257
unicode-display_width (2.5.0)
261-
webpacker (5.4.4)
262-
activesupport (>= 5.2)
263-
rack-proxy (>= 0.6.1)
264-
railties (>= 5.2)
265-
semantic_range (>= 2.3.0)
266258
websocket-driver (0.7.6)
267259
websocket-extensions (>= 0.1.0)
268260
websocket-extensions (0.1.5)
@@ -298,7 +290,6 @@ DEPENDENCIES
298290
sprockets (~> 3.0)
299291
sprockets-rails
300292
standard
301-
webpacker (>= 4.1)
302293

303294
BUNDLED WITH
304295
2.5.16

‎gemfiles/rails_7.1.gemfile‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
source 'https://rubygems.org'
22

33
gem 'rails', '~> 7.1.0'
4-
gem 'webpacker', '>= 4.1'
54

65
group :development, :test do
76
gem 'guard', require: false

‎gemfiles/rails_7.1.gemfile.lock‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,6 @@ GEM
186186
stringio
187187
racc (1.8.0)
188188
rack (2.2.9)
189-
rack-proxy (0.7.7)
190-
rack
191189
rack-session (1.0.2)
192190
rack (< 3)
193191
rack-test (2.1.0)
@@ -253,7 +251,6 @@ GEM
253251
rubocop (>= 1.48.1, < 2.0)
254252
rubocop-ast (>= 1.31.1, < 2.0)
255253
ruby-progressbar (1.13.0)
256-
semantic_range (3.0.0)
257254
shellany (0.0.1)
258255
simplecov (0.22.0)
259256
docile (~> 1.1)
@@ -288,11 +285,6 @@ GEM
288285
tzinfo (2.0.6)
289286
concurrent-ruby (~> 1.0)
290287
unicode-display_width (2.5.0)
291-
webpacker (5.4.4)
292-
activesupport (>= 5.2)
293-
rack-proxy (>= 0.6.1)
294-
railties (>= 5.2)
295-
semantic_range (>= 2.3.0)
296288
webrick (1.8.1)
297289
websocket-driver (0.7.6)
298290
websocket-extensions (>= 0.1.0)
@@ -329,7 +321,6 @@ DEPENDENCIES
329321
sprockets (~> 3.0)
330322
sprockets-rails
331323
standard
332-
webpacker (>= 4.1)
333324

334325
BUNDLED WITH
335326
2.5.16

‎lib/serviceworker/handlers/webpacker_handler.rb‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,25 @@
11
# frozen_string_literal: true
22

3-
require "rack/file"
4-
require "webpacker"
3+
require 'rack/file'
4+
begin
5+
require 'webpacker'
6+
rescue LoadError
7+
# ignore
8+
end
59

610
module ServiceWorker
711
module Handlers
812
class WebpackerHandler
913
def call(env)
10-
path_info = env.fetch("serviceworker.asset_name")
14+
path_info = env.fetch('serviceworker.asset_name')
1115

1216
path = Webpacker.manifest.lookup(path_info)
1317

1418
if Webpacker.dev_server.running?
1519
proxy = Webpacker::DevServerProxy.new
16-
proxy.call(env.merge("PATH_INFO" => path))
20+
proxy.call(env.merge('PATH_INFO' => path))
1721
else
18-
file_server.call(env.merge("PATH_INFO" => path))
22+
file_server.call(env.merge('PATH_INFO' => path))
1923
end
2024
end
2125

‎test/sample/package.json‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
{
22
"dependencies": {
3-
"@rails/webpacker": "3.5.5"
43
},
54
"devDependencies": {
6-
"webpack-dev-server": "3.7.2"
75
}
86
}

0 commit comments

Comments
 (0)