Skip to content

Commit 31362c6

Browse files
authored
Merge pull request #138 from Kamahl19/use-flexboxgrid2
Use evgenyrodionov/flexboxgrid2 instead of roylee0704/react-flexbox-grid
2 parents 6d912c3 + 85b7543 commit 31362c6

File tree

12 files changed

+31
-18
lines changed

12 files changed

+31
-18
lines changed

doc/app/components/hero/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const Hero = () => {
1111
<h1 className={style.headline}>React-FlexBox-Grid</h1>
1212
</Row>
1313
<Row className={style.description} center="xs">
14-
<code>React(CSS-Modules(flexboxgrid.css));</code>
14+
<code>React(CSS-Modules(flexboxgrid2.css));</code>
1515
</Row>
1616
<Row center="xs">
1717
<Button url="https://github.com/roylee0704/react-flexbox-grid">Github</Button>

doc/app/components/home/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const Home = () => (
2626
<Grid fluid className={home.wrap}>
2727
<Section
2828
title="Responsive"
29-
description="Responsive modifiers enable specifying different column sizes, offsets, alignment and distribution at xs, sm, md & lg viewport widths.">
29+
description="Responsive modifiers enable specifying different column sizes, offsets, alignment and distribution at xs, sm, md, lg & xl viewport widths.">
3030
<Row>
3131
<Box type="row" xs={12} sm={3} md={2} lg={1} />
3232
<Box type="row" xs={6} sm={6} md={8} lg={10} />

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"react-component"
2424
],
2525
"dependencies": {
26-
"flexboxgrid": "^6.3.0",
26+
"flexboxgrid2": "^7.0.0-alpha7",
2727
"prop-types": "^15.5.8"
2828
},
2929
"devDependencies": {
@@ -48,7 +48,6 @@
4848
"expect": "^1.13.0",
4949
"express": "^4.13.3",
5050
"extract-text-webpack-plugin": "^0.8.2",
51-
"flexboxgrid": "^6.3.0",
5251
"isparta": "^4.0.0",
5352
"jsdom": "^7.0.2",
5453
"karma": "^1.6.0",

react-flexbox-grid.d.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import {Component} from 'react';
77

88
declare namespace __ReactFlexboxGrid {
9-
type ViewportSizeType = 'xs' | 'sm' | 'md' | 'lg';
9+
type ViewportSizeType = 'xs' | 'sm' | 'md' | 'lg' | 'xl';
1010
type ColumnSizeType = number | boolean;
1111

1212
export interface GridProps {
@@ -34,10 +34,12 @@ declare namespace __ReactFlexboxGrid {
3434
readonly sm?: ColumnSizeType,
3535
readonly md?: ColumnSizeType,
3636
readonly lg?: ColumnSizeType,
37+
readonly xl?: ColumnSizeType,
3738
readonly xsOffset?: number,
3839
readonly smOffset?: number,
3940
readonly mdOffset?: number,
4041
readonly lgOffset?: number,
42+
readonly xlOffset?: number,
4143
readonly first?: ViewportSizeType,
4244
readonly last?: ViewportSizeType,
4345
readonly className?: string,

src/classNames.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import styles from 'flexboxgrid/dist/flexboxgrid.css';
1+
import styles from 'flexboxgrid2/flexboxgrid2.css';
22

33
export default function getClass(className) {
44
return (styles && styles[className]) ? styles[className] : className;

src/components/Col.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,12 @@ const propTypes = {
99
sm: ColumnSizeType,
1010
md: ColumnSizeType,
1111
lg: ColumnSizeType,
12+
xl: ColumnSizeType,
1213
xsOffset: PropTypes.number,
1314
smOffset: PropTypes.number,
1415
mdOffset: PropTypes.number,
1516
lgOffset: PropTypes.number,
17+
xlOffset: PropTypes.number,
1618
first: ViewportSizeType,
1719
last: ViewportSizeType,
1820
className: PropTypes.string,
@@ -25,10 +27,12 @@ const classMap = {
2527
sm: 'col-sm',
2628
md: 'col-md',
2729
lg: 'col-lg',
30+
xl: 'col-xl',
2831
xsOffset: 'col-xs-offset',
2932
smOffset: 'col-sm-offset',
3033
mdOffset: 'col-md-offset',
31-
lgOffset: 'col-lg-offset'
34+
lgOffset: 'col-lg-offset',
35+
xlOffset: 'col-xl-offset'
3236
};
3337

3438
function isInteger(value) {

src/types.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
import PropTypes from 'prop-types';
22

33
export const ColumnSizeType = PropTypes.oneOfType([PropTypes.number, PropTypes.bool]);
4-
export const ViewportSizeType = PropTypes.oneOf(['xs', 'sm', 'md', 'lg']);
4+
export const ViewportSizeType = PropTypes.oneOf(['xs', 'sm', 'md', 'lg', 'xl']);

test/classNames.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import expect from 'expect';
2-
import style from 'flexboxgrid';
2+
import style from 'flexboxgrid2';
33
import getClass from '../src/classNames';
44

55
describe('classNames lookups', () => {

test/components/Col.spec.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,20 @@ import expect from 'expect';
22
import React from 'react';
33
import TestUtils from 'react-addons-test-utils';
44
import Col, { getColumnProps } from '../../src/components/Col';
5-
import style from 'flexboxgrid';
5+
import style from 'flexboxgrid2';
66

77
const renderer = TestUtils.createRenderer();
88

99
describe('Col', () => {
1010
it('Should add classes equals to props', () => {
11-
renderer.render(<Col xs={12} sm={8} md={6} lg={4} />);
11+
renderer.render(<Col xs={12} sm={8} md={6} lg={4} xl={2} />);
1212
const { type, props: { className } } = renderer.getRenderOutput();
1313
expect(type).toBe('div');
1414
expect(className).toContain(style['col-xs-12']);
1515
expect(className).toContain(style['col-sm-8']);
1616
expect(className).toContain(style['col-md-6']);
1717
expect(className).toContain(style['col-lg-4']);
18+
expect(className).toContain(style['col-xl-2']);
1819
});
1920

2021
it('Computes the column properties', () => {
@@ -38,16 +39,17 @@ describe('Col', () => {
3839
});
3940

4041
it('Should support auto-width', () => {
41-
renderer.render(<Col xs sm md lg />);
42+
renderer.render(<Col xs sm md lg xl />);
4243
const { className } = renderer.getRenderOutput().props;
4344
expect(className).toContain(style['col-xs']);
4445
expect(className).toContain(style['col-sm']);
4546
expect(className).toContain(style['col-md']);
4647
expect(className).toContain(style['col-lg']);
48+
expect(className).toContain(style['col-xl']);
4749
});
4850

4951
it('Should support custom tag name', () => {
50-
renderer.render(<Col xs sm md lg tagName="li" />);
52+
renderer.render(<Col xs sm md lg xl tagName="li" />);
5153

5254
expect(renderer.getRenderOutput().type).toBe('li');
5355
});

test/components/Grid.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import expect from 'expect';
22
import React from 'react';
33
import TestUtils from 'react-addons-test-utils';
44
import Grid from '../../src/components/Grid';
5-
import style from 'flexboxgrid';
5+
import style from 'flexboxgrid2';
66

77
const renderer = TestUtils.createRenderer();
88

0 commit comments

Comments
 (0)