Skip to content

Commit 44c0817

Browse files
authored
Merge pull request #30 from rtCamp/update/readme
Update readme with SKIP_FOLDERS example
2 parents 6e2906c + 7ae73c6 commit 44c0817

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,20 @@ name: Run PHPCS on pull requests
2121

2222
on: pull_request
2323

24+
name: Inspections
2425
jobs:
2526
phpcs:
27+
name: Run PHPCS inspection
2628
runs-on: ubuntu-latest
2729
steps:
2830
- uses: actions/checkout@v2
2931
with:
3032
ref: ${{ github.event.pull_request.head.sha }}
31-
- uses: docker://rtcamp/action-phpcs-code-review:v2.0.0
33+
- name: Run PHPCS inspection
34+
uses: rtCamp/action-phpcs-code-review@master
3235
env:
3336
GH_BOT_TOKEN: ${{ secrets.GH_BOT_TOKEN }}
37+
SKIP_FOLDERS: "tests,.github"
3438
with:
3539
args: "WordPress,WordPress-Core,WordPress-Docs"
3640
```
@@ -43,10 +47,6 @@ By default, pull request will be reviwed using WordPress coding and documentatio
4347

4448
4. In case you want to skip PHPCS scanning in any pull request, add `[do-not-scan]` in the PR description. You can add it anywhere in the description and it will skip the action run for that pull request.
4549

46-
---
47-
48-
Side note: in the usage example, we have used `docker://rtcamp/action-phpcs-code-review:v2.0.0`, which is the docker image set up with automated builds on this repo. It will always have the latest code of this repo. Instead of using docker image you can also use the repo url in it: `rtCamp/action-phpcs-code-review@v2.0.0`. The disadvantage using the repo url is that GitHub actions now builds the docker image from url every time action is executed (does not cache the docker image after first run _by default_ as it used to do in beta. You need to cache them seprately). That consumes a fairly good amount of time in action run. Leading to a longer running job as well as more billing (if used in private repo).
49-
5050
## GitHub Token Creation
5151

5252
You can create [GitHub Token from here](https://github.com/settings/tokens).

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: 'This will run phpcs on PRs'
33
author: 'rtCamp'
44
runs:
55
using: 'docker'
6-
image: 'Dockerfile'
6+
image: 'docker://rtcamp/action-phpcs-code-review:v2.0.1'
77
branding:
88
icon: 'check-circle'
99
color: 'green'

0 commit comments

Comments
 (0)