Skip to content

Commit c30a169

Browse files
committed
Merge branch 'master' into release/v0.4.0
* master: Honor 80 character line length (if possible) Fix changelog HTTP link Use custom docker build Make dedicated rule for build on TravisCI
2 parents 9bcd5d9 + cb83429 commit c30a169

File tree

4 files changed

+34
-22
lines changed

4 files changed

+34
-22
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ addons:
99
- make
1010

1111
script:
12-
- make test-build
12+
- make travis-build

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ build:
1616
--build-arg VCS_REF=`git rev-parse --short HEAD` \
1717
--build-arg BUILD_DATE=`date -u +"%Y-%m-%dT%H:%M:%SZ"` \
1818
--build-arg VERSION=$(IMAGE_VERSION) \
19-
-t $(IMAGE_FQN) .
19+
-t $(IMAGE_NAME):local-build .
2020

21-
test-build:
21+
travis-build:
2222
@docker build \
23-
--build-arg VCS_REF=`git rev-parse --short HEAD` \
23+
--build-arg VCS_REF=$(TRAVIS_COMMIT) \
2424
--build-arg BUILD_DATE=`date -u +"%Y-%m-%dT%H:%M:%SZ"` \
2525
--build-arg VERSION=$(IMAGE_VERSION) \
26-
-t $(IMAGE_NAME):testbuild .
26+
-t $(IMAGE_NAME):travis-build .

README.md

Lines changed: 22 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,26 @@
22

33
## nginx-php Dockerfile
44

5-
This repository contains source code of [rtucek/nginx-php](https://hub.docker.com/r/rtucek/nginx-php).
5+
This repository contains source code of
6+
[rtucek/nginx-php](https://hub.docker.com/r/rtucek/nginx-php).
67

78
## Content
89

9-
Nginx and PHP are compiled in a specific version. Consult the [CHANGELOG.md](./CHANGELOG.md) file
10-
for further version details. [PHP Composer](https://getcomposer.org/) is already installed and ready
11-
for use.
10+
Nginx and PHP are compiled in a specific version. Consult the
11+
[CHANGELOG.md](https://github.com/rtucek/nginx-php/blob/master/CHANGELOG.md)
12+
file for further version details. [PHP Composer](https://getcomposer.org/) is
13+
already installed and ready for use.
1214

13-
Xdebug is installed as shared extension, but not activated. Start the container with env
14-
ENABLE_XDEBUG=1 to enable the extension.
15+
Xdebug is installed as shared extension, but not activated. Start the container
16+
with env ENABLE_XDEBUG=1 to enable the extension.
1517

16-
The Nginx and PHP-FPM master processes are controlled by [Honcho](https://github.com/nickstenning/honcho).
17-
Honcho was chosen over Supervisor, because honcho will exit and kill the container if either Nginx
18-
or PHP's master process dye for any reason. If you want have to have the container restarted
19-
automatically, you may want to use
20-
[Docker's restart](https://docs.docker.com/engine/reference/run/#restart-policies---restart) policy.
18+
The Nginx and PHP-FPM master processes are controlled by
19+
[Honcho](https://github.com/nickstenning/honcho). Honcho was chosen over
20+
Supervisor, because honcho will exit and kill the container if either Nginx or
21+
PHP's master process dye for any reason. If you want have to have the container
22+
restarted automatically, you may want to use
23+
[Docker's restart](https://docs.docker.com/engine/reference/run/#restart-policies---restart)
24+
policy.
2125

2226
## Usage
2327

@@ -30,8 +34,8 @@ docker run --restart=always -v /path/to/php/source/:/usr/local/nginx/html/ rtuce
3034

3135
## Advanced configuration
3236

33-
You by default, the image is configured to work out of the box, however you may add your own Nginx or
34-
PHP related configuration files.
37+
You by default, the image is configured to work out of the box, however you may
38+
add your own Nginx or PHP related configuration files.
3539

3640
### Nginx
3741

@@ -47,9 +51,9 @@ Mount your custom `nginx.conf` file at `/usr/local/nginx/conf/nginx.conf`.
4751

4852
### Xdebug
4953

50-
Xdebug was installed mainly with the idea of providing code coverage for PHPUnit. Thus it's not
51-
configured for any specific use case. You can [configure Xdebug](https://xdebug.org/docs/all) via
52-
`php.ini` if desired.
54+
Xdebug was installed mainly with the idea of providing code coverage for
55+
PHPUnit. Thus it's not configured for any specific use case. You can
56+
[configure Xdebug](https://xdebug.org/docs/all) via `php.ini` if desired.
5357

5458
### Crontab
5559

@@ -65,7 +69,8 @@ whenever possible).
6569

6670
### Honcho
6771

68-
If you want to overwrite the default Honcho configuration - mount your custom `Procfile` file at `/`.
72+
If you want to overwrite the default Honcho configuration - mount your custom
73+
`Procfile` file at `/`.
6974

7075
## Todo
7176

hooks/build

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
#!/bin/sh
2+
3+
docker build \
4+
--build-arg VCS_REF=$SOURCE_COMMIT \
5+
--build-arg BUILD_DATE=`date -u +"%Y-%m-%dT%H:%M:%SZ"` \
6+
--build-arg VERSION=$DOCKER_TAG \
7+
-t $IMAGE_NAME .

0 commit comments

Comments
 (0)