Skip to content

Commit 23cefe0

Browse files
committed
add EnableCors attributes
1 parent a489544 commit 23cefe0

File tree

4 files changed

+9
-17
lines changed

4 files changed

+9
-17
lines changed

rubberduckvba.Server/Api/Admin/AdminController.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using Microsoft.AspNetCore.Authorization;
2+
using Microsoft.AspNetCore.Cors;
23
using Microsoft.AspNetCore.Mvc;
34
using Microsoft.Extensions.Options;
45

@@ -13,6 +14,7 @@ public class AdminController(ConfigurationOptions options, HangfireLauncherServi
1314
/// </summary>
1415
/// <returns>The unique identifier of the enqueued job.</returns>
1516
[Authorize("github")]
17+
[EnableCors("CorsPolicy")]
1618
[HttpPost("admin/update/xmldoc")]
1719
public IActionResult UpdateXmldocContent()
1820
{
@@ -25,6 +27,7 @@ public IActionResult UpdateXmldocContent()
2527
/// </summary>
2628
/// <returns>The unique identifier of the enqueued job.</returns>
2729
[Authorize("github")]
30+
[EnableCors("CorsPolicy")]
2831
[HttpPost("admin/update/tags")]
2932
public IActionResult UpdateTagMetadata()
3033
{

rubberduckvba.Server/Api/Admin/WebhookController.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using Microsoft.AspNetCore.Authorization;
2+
using Microsoft.AspNetCore.Cors;
23
using Microsoft.AspNetCore.Mvc;
34
using System.Text.Json;
45

@@ -21,6 +22,7 @@ public WebhookController(
2122
}
2223

2324
[Authorize("webhook")]
25+
[EnableCors("webhookPolicy")]
2426
[HttpPost("webhook/github")]
2527
public async Task<IActionResult> GitHub([FromBody] dynamic body) =>
2628
GuardInternalAction(() =>

rubberduckvba.Server/Api/Auth/AuthController.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using Microsoft.AspNetCore.Authorization;
2+
using Microsoft.AspNetCore.Cors;
23
using Microsoft.AspNetCore.Mvc;
34
using Microsoft.Extensions.Options;
45
using Octokit;
@@ -70,6 +71,7 @@ public IActionResult Index()
7071
}
7172

7273
[HttpPost("auth/signin")]
74+
[EnableCors("CorsPolicy")]
7375
[AllowAnonymous]
7476
public IActionResult SessionSignIn(SignInViewModel vm)
7577
{
@@ -106,6 +108,7 @@ public IActionResult SessionSignIn(SignInViewModel vm)
106108
}
107109

108110
[HttpPost("auth/github")]
111+
[EnableCors("CorsPolicy")]
109112
[AllowAnonymous]
110113
public IActionResult OnGitHubCallback(SignInViewModel vm)
111114
{

rubberduckvba.Server/Program.cs

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public static void Main(string[] args)
4545

4646
builder.Services.AddCors(builder =>
4747
{
48-
builder.AddDefaultPolicy(policy =>
48+
builder.AddPolicy("CorsPolicy", policy =>
4949
{
5050
policy
5151
.SetIsOriginAllowed(origin => true)
@@ -54,22 +54,6 @@ public static void Main(string[] args)
5454
.AllowCredentials()
5555
.Build();
5656
});
57-
58-
builder.AddPolicy("webhookPolicy", policy =>
59-
{
60-
policy
61-
#if DEBUG
62-
.SetIsOriginAllowed(origin => true)
63-
#else
64-
.SetIsOriginAllowedToAllowWildcardSubdomains()
65-
.WithOrigins("*.github.com")
66-
#endif
67-
.WithHeaders("Content-Type", "X-GitHub-Event", "X-GitHub-Delivery", "X-GitHub-Hook-ID", "X-Hub-Signature", "X-Hub-Signature256")
68-
.WithMethods("POST")
69-
.DisallowCredentials()
70-
.SetPreflightMaxAge(TimeSpan.FromHours(48))
71-
.Build();
72-
});
7357
});
7458

7559
builder.Services.AddAuthentication(options =>

0 commit comments

Comments
 (0)