Skip to content

Commit 7c27366

Browse files
Add backwards compatibility for DEPLOYMENT_URL_ID
Co-authored-by: adrian <adrian@runllama.ai>
1 parent 4a8493b commit 7c27366

File tree

4 files changed

+36
-6
lines changed

4 files changed

+36
-6
lines changed

test-proj/ui/src/vite-env.d.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ interface ImportMetaEnv {
77
// injected from llama_deploy
88
readonly VITE_LLAMA_DEPLOY_BASE_PATH: string;
99
readonly VITE_LLAMA_DEPLOY_DEPLOYMENT_NAME: string;
10+
// deprecated; kept for backwards compat
11+
readonly VITE_LLAMA_DEPLOY_DEPLOYMENT_URL_ID?: string;
1012
readonly VITE_LLAMA_DEPLOY_PROJECT_ID: string;
1113
}
1214

test-proj/ui/vite.config.ts

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,14 @@ import path from "path";
44

55
// https://vitejs.dev/config/
66
export default defineConfig(({}) => {
7-
const deploymentId = process.env.LLAMA_DEPLOY_DEPLOYMENT_URL_ID;
7+
// Prefer the new NAME env; fall back to deprecated URL_ID for backwards compat
8+
const deploymentName =
9+
process.env.LLAMA_DEPLOY_DEPLOYMENT_NAME ||
10+
process.env.LLAMA_DEPLOY_DEPLOYMENT_URL_ID;
11+
// If only URL_ID is set, populate NAME for downstream code expecting it
12+
if (!process.env.LLAMA_DEPLOY_DEPLOYMENT_NAME && process.env.LLAMA_DEPLOY_DEPLOYMENT_URL_ID) {
13+
process.env.LLAMA_DEPLOY_DEPLOYMENT_NAME = process.env.LLAMA_DEPLOY_DEPLOYMENT_URL_ID;
14+
}
815
const basePath = process.env.LLAMA_DEPLOY_DEPLOYMENT_BASE_PATH;
916
const projectId = process.env.LLAMA_DEPLOY_PROJECT_ID;
1017
const port = process.env.PORT ? Number(process.env.PORT) : 3000;
@@ -26,8 +33,14 @@ export default defineConfig(({}) => {
2633
},
2734
base: basePath,
2835
define: {
29-
"import.meta.env.VITE_LLAMA_DEPLOY_DEPLOYMENT_NAME":
30-
JSON.stringify(deploymentId),
36+
// Primary define uses NAME
37+
"import.meta.env.VITE_LLAMA_DEPLOY_DEPLOYMENT_NAME": JSON.stringify(
38+
deploymentName
39+
),
40+
// Keep deprecated URL_ID define for downstream consumers that still reference it
41+
"import.meta.env.VITE_LLAMA_DEPLOY_DEPLOYMENT_URL_ID": JSON.stringify(
42+
process.env.LLAMA_DEPLOY_DEPLOYMENT_URL_ID || deploymentName
43+
),
3144
"import.meta.env.VITE_LLAMA_DEPLOY_DEPLOYMENT_BASE_PATH": JSON.stringify(basePath),
3245
...(projectId && {
3346
"import.meta.env.VITE_LLAMA_DEPLOY_PROJECT_ID":

ui/src/vite-env.d.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ interface ImportMetaEnv {
77
// injected from llama_deploy
88
readonly VITE_LLAMA_DEPLOY_BASE_PATH: string;
99
readonly VITE_LLAMA_DEPLOY_DEPLOYMENT_NAME: string;
10+
// deprecated; kept for backwards compat
11+
readonly VITE_LLAMA_DEPLOY_DEPLOYMENT_URL_ID?: string;
1012
readonly VITE_LLAMA_DEPLOY_PROJECT_ID: string;
1113
}
1214

ui/vite.config.ts

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,14 @@ import path from "path";
44

55
// https://vitejs.dev/config/
66
export default defineConfig(({}) => {
7-
const deploymentId = process.env.LLAMA_DEPLOY_DEPLOYMENT_URL_ID;
7+
// Prefer the new NAME env; fall back to deprecated URL_ID for backwards compat
8+
const deploymentName =
9+
process.env.LLAMA_DEPLOY_DEPLOYMENT_NAME ||
10+
process.env.LLAMA_DEPLOY_DEPLOYMENT_URL_ID;
11+
// If only URL_ID is set, populate NAME for downstream code expecting it
12+
if (!process.env.LLAMA_DEPLOY_DEPLOYMENT_NAME && process.env.LLAMA_DEPLOY_DEPLOYMENT_URL_ID) {
13+
process.env.LLAMA_DEPLOY_DEPLOYMENT_NAME = process.env.LLAMA_DEPLOY_DEPLOYMENT_URL_ID;
14+
}
815
const basePath = process.env.LLAMA_DEPLOY_DEPLOYMENT_BASE_PATH;
916
const projectId = process.env.LLAMA_DEPLOY_PROJECT_ID;
1017
const port = process.env.PORT ? Number(process.env.PORT) : 3000;
@@ -26,8 +33,14 @@ export default defineConfig(({}) => {
2633
},
2734
base: basePath,
2835
define: {
29-
"import.meta.env.VITE_LLAMA_DEPLOY_DEPLOYMENT_NAME":
30-
JSON.stringify(deploymentId),
36+
// Primary define uses NAME
37+
"import.meta.env.VITE_LLAMA_DEPLOY_DEPLOYMENT_NAME": JSON.stringify(
38+
deploymentName
39+
),
40+
// Keep deprecated URL_ID define for downstream consumers that still reference it
41+
"import.meta.env.VITE_LLAMA_DEPLOY_DEPLOYMENT_URL_ID": JSON.stringify(
42+
process.env.LLAMA_DEPLOY_DEPLOYMENT_URL_ID || deploymentName
43+
),
3144
"import.meta.env.VITE_LLAMA_DEPLOY_DEPLOYMENT_BASE_PATH": JSON.stringify(basePath),
3245
...(projectId && {
3346
"import.meta.env.VITE_LLAMA_DEPLOY_PROJECT_ID":

0 commit comments

Comments
 (0)