Skip to content

Commit b49311a

Browse files
committed
Cleanup: move Proxy properties into a secondary grouping
1 parent 275e144 commit b49311a

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

src/main/java/com/dtolabs/rundeck/plugin/resources/ec2/EC2ResourceModelSourceFactory.java

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,10 @@ public ResourceModelSource createResourceModelSource(Properties configuration) t
9393
return null;
9494
}
9595

96-
static Description DESC = DescriptionBuilder.builder()
96+
public static final Map<String, Object> PROXY_OPTIONS = Map.of(
97+
StringRenderingConstants.GROUP_NAME, "Proxy",
98+
StringRenderingConstants.GROUPING, "secondary"
99+
);
97100

98101
public static final Map<String, Object> PASSWORD_OPTIONS = Collections.singletonMap(StringRenderingConstants.DISPLAY_TYPE_KEY, StringRenderingConstants.DisplayType.PASSWORD);
99102

@@ -173,9 +176,11 @@ public ResourceModelSource createResourceModelSource(Properties configuration) t
173176
.property(PropertyUtil.string(REGION, "Region", "AWS EC2 region.",
174177
false,
175178
null))
176-
.property(PropertyUtil.string(HTTP_PROXY_HOST, "HTTP Proxy Host", "HTTP Proxy Host Name, or blank for default", false, null))
177-
.property(PropertyUtil.integer(HTTP_PROXY_PORT, "HTTP Proxy Port", "HTTP Proxy Port, or blank for 80", false, "80"))
178-
.property(PropertyUtil.string(HTTP_PROXY_USER, "HTTP Proxy User", "HTTP Proxy User Name, or blank for default", false, null))
179+
.property(PropertyUtil.string(HTTP_PROXY_HOST, "HTTP Proxy Host", "HTTP Proxy Host Name, or blank for default", false, null, null,null,
180+
PROXY_OPTIONS
181+
))
182+
.property(PropertyUtil.integer(HTTP_PROXY_PORT, "HTTP Proxy Port", "HTTP Proxy Port, or blank for 80", false, "80",null,null,PROXY_OPTIONS))
183+
.property(PropertyUtil.string(HTTP_PROXY_USER, "HTTP Proxy User", "HTTP Proxy User Name, or blank for default", false, null,null,null,PROXY_OPTIONS))
179184
.property(
180185
PropertyUtil.string(
181186
HTTP_PROXY_PASS,
@@ -185,7 +190,11 @@ public ResourceModelSource createResourceModelSource(Properties configuration) t
185190
null,
186191
null,
187192
null,
188-
Collections.singletonMap("displayType", (Object) StringRenderingConstants.DisplayType.PASSWORD)
193+
Map.of(
194+
StringRenderingConstants.GROUP_NAME, "Proxy",
195+
StringRenderingConstants.GROUPING, "secondary",
196+
StringRenderingConstants.DISPLAY_TYPE_KEY, StringRenderingConstants.DisplayType.PASSWORD
197+
)
189198
)
190199
)
191200
.property(PropertyUtil.string(MAPPING_PARAMS, "Mapping Params",

0 commit comments

Comments
 (0)