Extract crates_io_heroku crate with commit() fns
#12323
Merged
+142
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new workspace crate to centralize access to Heroku-specific environment variables, starting with `HEROKU_SLUG_COMMIT`. The new `slug_commit()` function is now used in: - Sentry release tracking - Site metadata API endpoint - Database dump metadata Documentation notes that the environment variable is provided by the `runtime-dyno-metadata` Heroku Labs feature.
Support `HEROKU_BUILD_COMMIT` environment variable, which is the current standard for retrieving the deployed commit SHA from Heroku. This variable is provided by the `runtime-dyno-build-metadata` Labs feature. `HEROKU_SLUG_COMMIT` remains supported via `slug_commit()` for backward compatibility, though it is deprecated by Heroku.
Use `HEROKU_BUILD_COMMIT` first, falling back to `HEROKU_SLUG_COMMIT` for backward compatibility with deployments using the older `runtime-dyno-metadata` Labs feature.
Turbo87
added
C-internal 🔧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new workspace crate to centralize access to Heroku-specific environment variables.
The crate supports
HEROKU_SLUG_COMMITand the newerHEROKU_BUILD_COMMIT. It provides acommit()fn that tries both environment variables and returns whichever it finds.The new
commit()function is now used in:see https://devcenter.heroku.com/articles/dyno-metadata